Relax lock when updating job history information #7577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
added
bgw
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7577 +/- ##
==========================================
+ Coverage 80.06% 82.35% +2.28%
==========================================
Files 190 238 +48
Lines 37181 43721 +6540
Branches 9450 10971 +1521
==========================================
+ Hits 29770 36007 +6237
- Misses 2997 3382 +385
+ Partials 4414 4332 -82 ☔ View full report in Codecov by Sentry. |
mkindahl
approved these changes
Jan 8, 2025
fabriziomello
force-pushed
the
relax_job_history_lock
branch
2 times, most recently
from
f029cf4 to
471f097
Compare
In timescale#6767 we introduced the ability to track job execution history, but looks like we exaggerated the lock level when marking the end of the job execution using `ShareRowExclusiveLock` that conflicts with autovacuum jobs that requires an `ShareUpdateExclusiveLock`, so relaxing the lock to `RowExclusiveLock` because we only update the tuple in the job execution history metadata table.
fabriziomello
force-pushed
the
relax_job_history_lock
branch
from
471f097 to
031735e
Compare
kpan2034
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6767 we introduced the ability to track job execution history, but looks like we exaggerated the lock level when marking the end of the job execution using
ShareRowExclusiveLockthat conflicts with autovacuum jobs that requires anShareUpdateExclusiveLock, so relaxing the lock toRowExclusiveLockbecause we only update the tuple in the job execution history metadata table.Disable-check: force-changelog-file