Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow max_length to be picked up automatically #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow max_length to be picked up automatically #11

wants to merge 2 commits into from

Conversation

timmygee
Copy link

  • Simplify widget code to use standard template approach
  • max_length now comes through to the widget from the CharField
  • Add support for optional change_color attribute to toggle color change feature

@timmygee
Allow max_length to be picked up automatically
acecd36 
* Simplify widget code to use standard template approach
* max_length now comes through to the widget from the CharField
* Add support for optional change_color attribute to toggle color change feature
@timmyomahony
Copy link
Owner

Thanks for the PR. To be honest it's a long time since I initially created this library so I can't remember the design decisions. I'm wondering will the template-driven widget approach break backward compatibility? Either way, I'll check this out asap.

@timmygee
Copy link
Author

timmygee commented Apr 4, 2019

Wow - totally forgot I did this. It was a busy time and I missed your reply!

Yeah it's possible that backwards compatibility might need to be built in. I can confirm working with Django 2+ series

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmygee @timmyomahony