Use base02 for magit-diff-hunk-heading-highlight
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-highlight` face is used for the currently selected hunk in the magit diff and revision views. It should be distinct from the non `- highlight` font to aid in naviation. Per [the guidelines](https://github.com/chriskempson/base16/blob/main/ styling.md), base02 is to be used for "Selection background," which seems apropos to me. It also looks much better in my emacs setup using base16-framer, for whatever that's worth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-highlightface is used for the currently selected hunk in the magit diff and revision views. It should be distinct from the non- highlightfont to aid in naviation.Per [the guidelines](https://github.com/chriskempson/base16/blob/main/ styling.md), base02 is to be used for "Selection background," which seems apropos to me. It also looks much better in my emacs setup using base16-framer, for whatever that's worth.
Rendering 1d48474 in my emacs:
Before
The point is on the header line for the first hunk, but there's no visual differentiation of the hunks.
After
Now the header for the first hunk is higlighted.
