Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ui.text.directory #21

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add ui.text.directory #21

merged 1 commit into from
Jan 10, 2025

Conversation

mattkang
Copy link
Contributor

@mattkang mattkang commented Dec 30, 2024 •
edited
Loading

Addresses #18. Chose base0D to be consistent with how ls and stylix color directories

@mattkang mattkang requested a review from a team as a code owner December 30, 2024 18:13
@mattkang mattkang requested review from krgn and removed request for a team December 30, 2024 18:13
@mattkang mattkang marked this pull request as draft December 30, 2024 18:19
@mattkang
Copy link
Contributor Author

mattkang commented Dec 30, 2024 •
edited
Loading

Converting to draft. Seems like there's an issue where this isn't rendering properly. Will investigate.

@paletochen can you comment on whether this works for you?

@paletochen
Copy link

Converting to draft. Seems like there's an issue where this isn't rendering properly. Will investigate.

@paletochen can you comment on whether this works for you?

If I modify default.mustache by changing it to a .toml file and fix the [palette] section to have actual color values... it works for me

@mattkang
Copy link
Contributor Author

@paletochen nice. Which version of helix are you on?

@paletochen
Copy link

@paletochen nice. Which version of helix are you on?

helix 24.7 (0134bb70)

@mattkang mattkang marked this pull request as ready for review January 9, 2025 17:04
JamyGolden
JamyGolden approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I haven't tested but since @paletochen has tested it I'll approve. Should I merge now?

@mattkang
Copy link
Contributor Author

mattkang commented Jan 10, 2025 •
edited
Loading

Thanks @JamyGolden! I think #18 can be closed upon merge

@JamyGolden JamyGolden merged commit 97e09cf into tinted-theming:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamyGolden JamyGolden JamyGolden approved these changes

@krgn krgn Awaiting requested review from krgn krgn is a code owner automatically assigned from tinted-theming/helix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkang @paletochen @JamyGolden