-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML5 Video #2
base: master
Are you sure you want to change the base?
HTML5 Video #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is a good start, but still needs a little work before it's done -- see my comments inline!
|
||
So you could add more contexts to your website. | ||
|
||
## What is a HTML5 Video? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to correct small erros like "a", which should be "an" here.
|
||
``` html | ||
<iframe width="854" height="480" src="https://www.youtube.com/embed/LSxElWwWVFE" frameborder="0" allowfullscreen></iframe> | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're going to use this embed ode, you should at least explain what it is. And some more details about why a YouTube video is difficult to add using <video>
would really enhance this tutorial quite a bit!
<source src="http://www.noiseaddicts.com/samples_1w72b820/4033.mp3" type="video/mp4"> | ||
</audio> | ||
|
||
<p> Try it out on <a href=https://jsbin.com/?output>Jsbin<a/>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL of jsbin is missing!
No description provided.