Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dots from serialized %genuine secret #231

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

midsum-salrux
Copy link
Contributor

We were seeing intermittent mismatches when reading the %genuine secret from the URL. After testing, they went away with this change.

@midsum-salrux midsum-salrux requested a review from arthyn October 13, 2023 15:14
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@arthyn arthyn merged commit 8671e37 into master Oct 13, 2023
1 check passed
@arthyn arthyn deleted the ns/genuine-followup branch October 13, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants