Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docket: call +fip appropriately #259

Merged
merged 1 commit into from
Feb 15, 2024
Merged

docket: call +fip appropriately #259

merged 1 commit into from
Feb 15, 2024

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Feb 13, 2024

/app/docket was failing to compile. +fip is no longer a parser, but we were still calling it as such.

Presumably introduced in #245, which is weird, because I'm pretty sure we ran the code there locally at the time.

It's no longer a parser, so stop calling as like such.
@Fang- Fang- added the bug Something isn't working label Feb 13, 2024
@Fang- Fang- requested a review from arthyn February 13, 2024 16:08
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm I think something happened when I merged that reverted this because it was previously correct

@arthyn arthyn merged commit 4fe50ce into develop Feb 15, 2024
1 check passed
@arthyn arthyn deleted the m/fip-unparse branch February 15, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants