groups: refactor to improve join speed, stability, and API #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAND-626 chat: prototype speeding up joins
Adjust update types to be more CRDT-like so we can send partial logs and never get out of sync. |
philipcmonk
force-pushed
the
hm/hackweek
branch
from
0142427 to
230c5a8
Compare
And update the normal seal type to use the new v-* prefix convention.
In some cases it would conflict with, or be easily confused for, a c=chat import. In those places, we leave it as d for the time being.
It was named this due to historic implementation path reasons (originally came from /app/DIary), but should match the concept it's actually dealing with (ChAnnels).
Instead of /ui, just / will now be given all available updates, and instead of /[nest]/ui, /[nest] will now get all updates for a given nest.
Whenever we talk to ourselves (that is, the local agent using the library) we should assume we're matching, and not negotiate versions explicitly.
Adds subscription endpoints at /~/negotiate/notify, optionally appending /json, to be notified about changes in the matching flag of a specific agent. Also enhances the scry endpoints, letting you scry for all known matching flags, or statusses, as both nouns and json. We hard-code the json endpoints as separate, so that we don't need mark files with conversions. This way, using the library remains as simple as just including the library file itself.
Co-authored-by: fang <[email protected]>
HAK-26: Documentation for channels API after refactor
These weren't getting handled properly, instead looking up/resending as the parent message. Here, we bring them to the level of compatibility of the old->new case: they turn into top-level messages when re-sent.
…r-group-hosts negotiation: host connection should always be matched, shouldn't assume
dms: block new club creation if some of the ships have version mismatch
…-banner unreads: fix issue with closing unread banner
…in-use-channel-compatibility negotiation: fix bad status in useChannelCompatibility
Chat was migrating refs largely correctly, but wasn't accounting for cases where the referenced message lives outside of the channel where the reference was posted. Heap and diary were not migrating refs correctly at all. Since converting old chat ids into new ones requires chat's lookup maps, we expose those for old chat state through a new /old scry endpoint in chat. We cache the scry, to avoid overhead for large/reference-heavy backlogs. Diary was not modifying references in top-level posts at all, which we also correct for here.
In rare cases, not handling these could result in a crash during the migration.
This was loud and scary.
Previously, we were looking up the partially-filled index by comment id, not parent post id, resulting in only the most recent comment being migrated.
That was a workaround for backend problems solved by #3035.
chat, heap, diary: migrate chat refs properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/tlon/issue/HAK-4/split-subscription-handling-logic-into-two-cases-urbit-urbit-and-urbit
Fixes LAND-626