Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tlon hosting upload method #2906

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Add tlon hosting upload method #2906

merged 8 commits into from
Oct 23, 2023

Conversation

guaraqe
Copy link
Contributor

@guaraqe guaraqe commented Oct 3, 2023

I will sync the PR with the proxy one, and open both at the same time, with the instructions for testing.

@guaraqe
Copy link
Contributor Author

guaraqe commented Oct 4, 2023

I added more details on how to test in https://github.com/tloncorp/ylem/pull/1715.

This PR has an issue I am not able to debug, which makes an "eyrie" button to appear in the frontend, blocking the upload button. It works if I remove the button, and the file is uploaded, but this is certainly a bug introduced by this PR.

I can try to solve it myself, but I need some guidance, as I don't understand the source of this problem.

@guaraqe guaraqe marked this pull request as ready for review October 4, 2023 04:42
@patosullivan
Copy link
Member

I added more details on how to test in https://github.com/tloncorp/ylem/pull/1715.

This PR has an issue I am not able to debug, which makes an "eyrie" button to appear in the frontend, blocking the upload button. It works if I remove the button, and the file is uploaded, but this is certainly a bug introduced by this PR.

I can try to solve it myself, but I need some guidance, as I don't understand the source of this problem.

That button only appears when running the app via the local dev server. Are you saying you ran npm run prod and still saw it? Or were you running dev?

@jamesacklin
Copy link
Member

@guaraqe Thanks! The "eyre" button is a piece of developer tooling to watch connections and subscriptions. You can toggle it with window.toggleDevTools() in the browser console.

@guaraqe
Copy link
Contributor Author

guaraqe commented Oct 4, 2023

Yes, but this button seems to appear because it detects some bug in the frontend. The question is: I don't understand what exactly is the bug, I was not able to identify it from the console logs or requests.

@patosullivan
Copy link
Member

Yes, but this button seems to appear because it detects some bug in the frontend. The question is: I don't understand what exactly is the bug, I was not able to identify it from the console logs or requests.

It appears all the time, by default, when you run the app locally.

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@arthyn arthyn merged commit 22338ff into develop Oct 23, 2023
1 check failed
@arthyn arthyn deleted the tlon-token-upload branch October 23, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants