meta: prevent user scaling #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAND-1116 Creating a new post in a notebook/gallery is buggy:
We're currently observing small bugs with posting to Galleries: And posting to Notebooks: RPReplay_Final1698098023 2.MOV The issue seems to be related to the handling for text fields, which causes the viewport to "zoom" inward, which is pretty janky to experience. |
jamesacklin
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed this fixes LAND-1116
Ultimately, we'll need to manually support pinch to zoom in specific situations by tracking touch events. I tried a few hacks to keep the behavior for image lightboxes, but none of them were both functional and low risk enough to warrant inclusion at this stage.