Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: fix drag and drop in chat threads #2995

Merged

Conversation

patosullivan
Copy link
Member

Fixes LAND-1110. We weren't using the currentTargetId in the handleDropWithTarget handler, we were just using whichever targetId we received in the parameters for the hook itself.

Copy link

linear bot commented Nov 6, 2023

LAND-1110 s3: attempting to drag/drop image in thread doesn't work

  • Open a thread
  • Attempt to paste an image and see the UI update saying you can paste in the field in the thread
  • Drag the image there
  • Observe when you do that the non-thread input box shows the spinner
  • Observe nothing upload (I saw nothing happen once, and I saw it appear in the non-thread input box once)

Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good

@patosullivan patosullivan merged commit d8cb8b1 into develop Nov 6, 2023
1 check failed
@patosullivan patosullivan deleted the po/land-1110-fix-drag-and-drop-in-chat-threads branch November 6, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants