DMs: frontend state management rewrite #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAND-1136 DMs: rewrite FE state mgmt
Front-end state management for DMs/MultiDMs is still janky. We’re still using our older zustand store method for state management. This was done to avoid some extra work, but it’s causing some issues with rendering updates when messages receive new replies. It’s also not ideal to use an entirely different paradigm for this one part of the app. We should rewrite the frontend to use react-query for DMs/MultiDMs. This is probably two or three days worth of grinding. |
latter-bolden
force-pushed
the
bd/hw-fe-dms
branch
from
a684c18 to
f23df2a
Compare
…to useChatState, and remove commented out useChatState references
…d of unused hooks
…ame trackedPosts to trackedWrits in several places, use trackedPokes for dm reply deletes, listen for/updated trackedWrits for delivered status
…ccessible after clicking join
LAND-1222 dms: paging is broken
Retrieving writs relies on scries returning older/newer cursors for fetching the next batch of data in either direction. Right now they're broken and always return null. They should correctly return an ID for the next/previous message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LAND-1136
Fixes LAND-1222