Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat: make sure we don't override existing saga values #3001

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Nov 13, 2023

OTT, this should fix LAND-1181

@arthyn arthyn requested review from patosullivan and Fang- November 13, 2023 17:19
Copy link

linear bot commented Nov 13, 2023

LAND-1181 old groups: version in/compatibility indicators misbehaving for chat

In old groups, when in a group for whose channels the hosts have upgraded, we correctly see a red version mismatch dot for collections, but chat channels continue displaying a green dot despite their host having upgraded. This is bad, because it makes the "we have not received the update yet, but the channel host has" case invisible & confusing to the user.

We have observed that:

  • /app/chat does store a net=[%sub host=~zod load=%.y saga=[%dex ver=1]] in the channel state correctly,
  • and that the frontend does receive a saga: { ahead: '1' } for the relevant channel from its /groups-ui/init/v0.json scry.

However, unclear at this time why it's not reflected in the status dot.

We have additionally observed the status dot being finnicky, sometimes staying grey until the profile of the host ship is clicked, which prompts connection re-try and turns it green, but unclear if that is related.

In any case, the primary problem here is that current mainnet isn't guaranteed to display a correct connectivity/version status indicator for chat channels, when it should just be consistent in giving a red dot for version mismatches. We may not be able to fix this without an "appetizer ota".

@arthyn arthyn merged commit 81dab7f into develop Nov 13, 2023
1 check passed
@arthyn arthyn deleted the hm/fix-chat-saga-handling branch November 13, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants