Group cloning for testing refactor migration on large groups #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAND-1218 meta: cloning tlon local backlog for mainnet testing
We need to test the Hack Week migration with a real, large group. Let's use the large archive of posts from Tlon Local as a corpus for testing. |
Fang-
reviewed
Nov 17, 2023
Fang-
approved these changes
Nov 17, 2023
arthyn
reviewed
Nov 20, 2023
desk/app/groups.hoon
Outdated
| =. cor | ||
| (emit %pass /groups/(scot %p our.bowl)/[q.flag]/create %agent [our.bowl %groups] %poke %group-create !>(create)) | ||
| =. cor | ||
| (emit %pass /groups/(scot %p p.flag)/[q.flag]/clone %agent [p.flag %groups] %watch /groups/(scot %p p.flag)/[q.flag]/clone) |
There was a problem hiding this comment.
If we sent this to our.bowl instead of p.flag would that let us clone groups w/o installing this on the host? seems like it might work
There was a problem hiding this comment.
this does in fact work (except on tlon local, likely because we trimmed the logs and the channel creation deltas are missing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on the existing transfer/import-channel code for archiving by allowing moves between ships
Fixes LAND-1218