dms: smoother joins & leaves #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAND-1225 dms: smooth out joins/leaves
My rsvp fix yesterday appears to be failing on the latest hackweek deploy. Joins go through, but the screen isn't updated immediately and refreshing is required. Leaves similarly execute, but the old message thread is still visible in the dms list. |
arthyn
approved these changes
Nov 20, 2023
| export function useDmUnreads() { | ||
| const dmUnreadsKey = ['dms', 'unreads']; |
There was a problem hiding this comment.
we actually should move these keys up and reuse them everywhere we use the unreads key
There was a problem hiding this comment.
agreed. Rather than doing it one off here, I'll open a separate PR to extract keys more consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the issue on the latest hackweek deploy where joining and leaving DMs and multi DMs succeed, but doesn't update the interface.
Fixes LAND-1225