Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up npm workspaces with shared package #3217

Closed
wants to merge 4 commits into from

Conversation

alecananian
Copy link
Contributor

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Changes

  • Updates repository to use npm workspaces
  • Creates shared package at packages/shared with sample shared type to start
  • Updates the web UI's group state manager to use the example shared type
  • Moves Spill app into monorepo architecture at apps/spill

Tested with my livenet ship:

  1. Delete all existing node_modules folders in your repo: rm -rf ./**/node_modules
  2. Install dependencies at the root level: npm i
  3. Navigate to the spill app cd apps/spill and start the Metro packager: npm start
  4. Plug in your device or start the iOS simulator and run spill: npm run ios

No changes were made to the way the web UI is run for now

Copy link

linear bot commented Feb 8, 2024

@alecananian
Copy link
Contributor Author

No longer relevant; will reopen later with a different app package

@alecananian alecananian closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant