Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up npm workspaces with shared package #3224

Merged
merged 17 commits into from
Feb 15, 2024

Conversation

alecananian
Copy link
Contributor

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Changes

  • Updates repository to use npm workspaces
  • Creates shared package at packages/shared with sample shared type to start
  • Updates the web UI's group state manager to use the example shared type
  • Moves Tlon mobile app into monorepo architecture at apps/tlon-mobile with bundle ID io.tlon.groups.staging

Tested with my livenet ship:

  1. Delete all existing node_modules folders in your repo: rm -rf ./**/node_modules
  2. Install dependencies at the root level: npm i
  3. Follow setup directions in apps/tlon-mobile/README.md
  4. Plug in your device or start the iOS simulator and run Tlon mobile: npm run dev:ios

No changes were made to the way the web UI is run for now

Copy link

linear bot commented Feb 9, 2024

@alecananian alecananian marked this pull request as draft February 9, 2024 04:55
@alecananian
Copy link
Contributor Author

Marking as draft because the rest of the CI workflows need updating. But the app package should be good for review.

@mrozanski
Copy link
Contributor

For the new bundle ID, we should use a distinctive app icon so it's. not the same as tlon-mobile's currently in production.
I'll followup in Linear.

@alecananian alecananian marked this pull request as ready for review February 10, 2024 01:55
@alecananian
Copy link
Contributor Author

Discussed with @mrozanski and @dnbrwstr, plan now is to move the ./ui folder to ./apps/tlon-web and leave the ./desk folder at the root of the repo since it's not a workspace package. cc @arthyn @Fang- any issues with this folder structure/naming?

@arthyn
Copy link
Member

arthyn commented Feb 12, 2024

@alecananian sounds good to me

@alecananian
Copy link
Contributor Author

@mrozanski The web code is now in apps/tlon-web with the PR workflow passing

@arthyn arthyn merged commit 6081bf2 into develop Feb 15, 2024
@arthyn arthyn deleted the alec/land-1498-monorepo branch February 15, 2024 22:26
@latter-bolden latter-bolden restored the alec/land-1498-monorepo branch March 4, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants