Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat: fix missing message input on mobile #3225

Merged
merged 1 commit into from
Feb 9, 2024
Merged

chat: fix missing message input on mobile #3225

merged 1 commit into from
Feb 9, 2024

Conversation

latter-bolden
Copy link
Member

OTT

Talk ripout removed an env var causing navbar padding insertion checks to fail. Removes the env var from our types and updates the checks.

Fixes LAND-1546

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@linear Linear
Copy link

linear bot commented Feb 9, 2024

LAND-1546 chat: input missing on mobile

patosullivan
patosullivan approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes sense.

arthyn
arthyn approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@latter-bolden latter-bolden merged commit 5402cbe into develop Feb 9, 2024
1 check passed
@latter-bolden latter-bolden deleted the lb/fix-input-padding branch February 9, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthyn arthyn arthyn approved these changes

@patosullivan patosullivan patosullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@latter-bolden @patosullivan @arthyn