channels: make reply scry response match mark type #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrying for a reply message would produce a noun marked with the %channel-reply mark, but the noun itself wouldn't nest in the type of that mark. Here, we add a cast to the appropriate type, and "unversion" the reply noun that was being produced to coerce it into the correct shape. Resolves LAND-1531.
arthyn
approved these changes
Feb 9, 2024
|
We don't depend on this scry endpoint ourselves (at least, I can't find scries for this endpoint in our codebase, and nothing has appeared to be broken by this), so no particular rush on this. It does make for a confusing outward-facing api, where correct usage breaks it, but we've received no reports of this being bugged from anyone. Technically, this PR constitutes a breaking scry api change, albeit a small one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrying for a reply message would produce a noun marked with the %channel-reply mark, but the noun itself wouldn't nest in the type of that mark.
Here, we add a cast to the appropriate type, and "unversion" the reply noun that was being produced to coerce it into the correct shape.
Resolves LAND-1531.