refs: fix issue with clicking links in refs #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LAND-1409. Fixes the issue where clicking a link within a ref would both follow the link and navigate to the ref. Fix consists of making sure the user is actually clicking on the ref itself, not the link. Further explanation in in-line comments.
latter-bolden
approved these changes
Feb 15, 2024
patosullivan
deleted the
po/land-1409-clicking-links-in-refs-should-not-cause-navigate-to-ref
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LAND-1409.
Fixes the issue where clicking a link within a ref would both follow the link and navigate to the ref.
Fix consists of making sure the user is actually clicking on the ref itself, not the link.
Further explanation in in-line comments.
Tested locally on livenet dev moons by making some refs with links in them.
PR Checklist