-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ops: merge staging back into develop #3251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ops: move dev to staging
…d prevent the modal flashing on page load
groups: make sure segmented groups are filtered from the main list on mobile
talk sunset: correctly register if you've already seen the sunset banner & add passive indicator on mobile
app: fix inconsistencies from previous talk/groups split
desktop nav: display unread count on messages tab
desktop nav: fix crashing error in new messages nav tab count
ops: need to reglob on staging
ops: fix canary deploy
ops: add log to deploy
ops: better defaulting github action input
messages: fix dm filter count
leap: QoL improvements for Talk expats
desktop sidebar: fix dropdown links for Leap and Landscape
desktop sidebar: fix double scrollbar and persist nav location when tab switching
Closed
arthyn
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes LAND-1574. We were using the unread state synced from the backend for the unread count on the messages tab button. This caused a delay in updating the count due to the delay in the updated state. If we switch to using the chat store unreads, the count updates immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTT
Using a temp branch to avoid merging Talk rip out into
staging
during conflict resolution.Fixes LAND-1575