Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mobile: add tab navigation #3261

Merged
merged 9 commits into from
Feb 20, 2024
Merged

mobile: add tab navigation #3261

merged 9 commits into from
Feb 20, 2024

Conversation

alecananian
Copy link
Contributor

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Changes

  • Adds tab bar navigation to the mobile app
  • Updates native flags on the web side to use shared type and adds a hide tab bar flag
Screen.Recording.2024-02-19.at.2.47.01.PM.mov

@linear Linear
Copy link

linear bot commented Feb 19, 2024

LAND-1503 mobile v2: Implement navigation tabs in RN

@alecananian
Copy link
Contributor Author

Icons can go in shared ui package when #3255 is ready

dnbrwstr
dnbrwstr approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@dnbrwstr dnbrwstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I've been poking at a tamagui-based Icon component that I can swap in once this + the other PR are merged.

@alecananian alecananian merged commit f4ef29a into develop Feb 20, 2024
1 check passed
@alecananian alecananian deleted the alec/land-1503-tabs branch February 20, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnbrwstr dnbrwstr dnbrwstr approved these changes

@patosullivan patosullivan Awaiting requested review from patosullivan

@mrozanski mrozanski Awaiting requested review from mrozanski

@arthyn arthyn Awaiting requested review from arthyn

@latter-bolden latter-bolden Awaiting requested review from latter-bolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecananian @dnbrwstr