db: use triggers and change table for reactivity on native #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patosullivan
requested review from
dnbrwstr,
davidisaaclee and
latter-bolden
…ry inserts/updates to the db. Stop adding duplicate posts to the flush queue in the change listener. Stop adding posts that were just inserted to the flush queue, we only want to invalidate if it's an update to an existing post.
…ertain we have new unreads
|
Fire at will |
latter-bolden
added a commit
that referenced
this pull request
Jan 10, 2025
Revert "db: use triggers and change table for reactivity on native (#4279)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes reactivity issue we were seeing on both platforms by:
updateHook.This also creates a new
BaseDbclass where shared code for both platforms can live.I tested this out in the sim on native and watched the CPU usage in xcode, didn't notice any difference over the current baseline (which I found to be pretty bad on initial channel load, fwiw).
fixes tlon-3317