Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobileAppToast: use settings state #4315

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

jamesacklin
Copy link
Member

  • Replaced local storage usage with settings state to manage the visibility of the mobile app toast.
  • Introduced a new property seenMobileAppToast in the settings state to track if the toast has been dismissed.
  • Updated the toast component to conditionally render based on the loading state and the new settings property.
  • Modified the dismiss button to update the settings state instead of local storage.

- Replaced local storage usage with settings state to manage the visibility of the mobile app toast.
- Introduced a new property `seenMobileAppToast` in the settings state to track if the toast has been dismissed.
- Updated the toast component to conditionally render based on the loading state and the new settings property.
- Modified the dismiss button to update the settings state instead of local storage.
Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jamesacklin jamesacklin merged commit 2d67eac into develop Jan 7, 2025
1 check passed
@jamesacklin jamesacklin deleted the ja/hard-dismiss-tm-notice branch January 7, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants