Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): userSession model #9629

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented Jan 10, 2025

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Jan 10, 2025
Copy link
Contributor Author

fengmk2 commented Jan 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 marked this pull request as ready for review January 10, 2025 07:33
@graphite-app graphite-app bot requested a review from Brooooooklyn January 10, 2025 07:33
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 99.13793% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (93c585a) to head (f8b9088).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/backend/server/src/models/user-session.ts 99.12% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9629      +/-   ##
==========================================
+ Coverage   52.80%   52.85%   +0.05%     
==========================================
  Files        2180     2181       +1     
  Lines       98469    98584     +115     
  Branches    16717    16720       +3     
==========================================
+ Hits        51993    52104     +111     
- Misses      45034    45040       +6     
+ Partials     1442     1440       -2     
Flag Coverage Δ
server-test 77.85% <99.13%> (+0.08%) ⬆️
unittest 32.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

fengmk2 commented Jan 10, 2025

user-session.spect.ts is not running

@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 2acfdba to c17b78a Compare January 10, 2025 08:25
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from c17b78a to 868fbaa Compare January 10, 2025 08:51
@fengmk2 fengmk2 changed the base branch from canary to 01-10-test_server_should_await_throwsasync_assert January 10, 2025 08:51
@fengmk2 fengmk2 changed the base branch from 01-10-test_server_should_await_throwsasync_assert to graphite-base/9629 January 10, 2025 09:08
@fengmk2 fengmk2 force-pushed the graphite-base/9629 branch from 75a371c to 93c585a Compare January 10, 2025 09:24
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 868fbaa to 2ebeca6 Compare January 10, 2025 09:24
@fengmk2 fengmk2 changed the base branch from graphite-base/9629 to canary January 10, 2025 09:25
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 2ebeca6 to 2d114ed Compare January 10, 2025 09:25
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 2d114ed to f8b9088 Compare January 10, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant