Repository navigation
upgrade Go toolchain to 1.26.10 (CVE-2026-111943) - #3
Conversation
Broly Security ScanCaution
Note Summary 16 actionable finding(s) in this PR
Main table: 4 shown, 12 omitted of 16 actionable finding(s) above the reporting threshold. See the repository Security tab for the full set. No finding is at or above
Dismiss false positivesTick a box to dismiss the finding; untick it to bring the finding back. That is the same as replying
Note Re-scan this PR anytime with
|
…v3.6.14 (GO-2026-6107)
|
SEC-3320 verify: bumped golangci-lint to v2.15.0 (action v9.3.0, SHA-pinned) since v1.54.2 can't typecheck Go 1.26, and bumped go.etcd.io/etcd/client/pkg/v3 to v3.6.14 (GO-2026-6107, HIGH). |
…ine 3.23 builder and scratch/alpine runtime images; disable setup-go cache in release workflow; fix staticcheck findings
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit afdd59f. Configure here.
| FROM scratch | ||
|
|
||
| COPY --from=0 /etc/ssl/certs /etc/ssl/certs | ||
| COPY --from=docker.io/library/alpine:3.23 /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt |
There was a problem hiding this comment.
Broken CA copy for multi-arch
High Severity
The runtime stage copies ca-certificates.crt from alpine:3.23 without pinning the source platform. Official alpine:3.23 has no linux/mips64 variant, so make docker and make release fail on the existing linux/amd64,linux/arm64,linux/mips64 matrix. The previous COPY --from=0 used the BUILDPLATFORM builder image and worked for every target.
Reviewed by Cursor Bugbot for commit afdd59f. Configure here.
…3 builder stage (keeps linux/mips64 builds working); kind test registry image moved to registry:3 (Alpine 3.24)


CVE-2026-111943 Go toolchain patch.
Version change
Go 1.21 / 1.21.5 / 1.21.x / golang:alpine (floating) -> 1.26.10. Go 1.26.10 adds the hard-coded crypto/x509 blocklist for 8 eMudhra/emSign intermediates. Go 1.25 and older get no fix.
Files changed
Dockerfile: buildergolang:1.21.5->golang:1.26.10-alpine3.23. Runtime stage is stillscratch, with the CA bundle (ca-certificates 20261020-r0) copied from the builder stage, so linux/amd64, arm64 and mips64 builds all keep working. CGO_ENABLED=0.tilt.Dockerfile:alpine:3.23+apk add ca-certificates(local Tilt dev image only).test/kind-with-registry.sh: local registryregistry:2(Alpine 3.18, EOL) ->registry:3(Alpine 3.24)..github/workflows/ci.yml,docker.yml,release.yml: setup-gogo-version1.21 / 1.21.x ->1.26.10. Everyuses:in these files is now pinned to a full commit SHA, with the original tag as a comment. The action versions are unchanged; this satisfies the org scanner's pinning rule.go.mod/go.sum: addedtoolchain go1.26.10. Dependency bumps for critical/high advisories only, each to the minimum version that fixes them:github.com/coredns/corednsv1.11.3 -> v1.14.7 (several HIGH advisories; v1.14.7 is the minimum that fixes all of them)google.golang.org/grpcv1.63.2 -> v1.83.2 (HIGH)golang.org/x/cryptov0.22.0 -> v0.55.0,golang.org/x/net-> v0.58.0,golang.org/x/oauth2-> v0.36.0,quic-go-> v0.61.0 (CRITICAL/HIGH; the final versions are the ones coredns/grpc require)k8s.io/{api,apimachinery,client-go}v0.29.3 -> v0.35.4,miekg/dnsv1.1.58 -> v1.1.72, plus many indirect deps (DataDog, AWS SDK v2, otel). These were pulled in by coredns v1.14.7 through MVS.goline went from 1.21 to 1.25.0. coredns v1.14.7 requires go >= 1.25, so this was forced.go mod tidyset it.Local build/test
go build ./... && go vet ./... && go test ./...with GOTOOLCHAIN=go1.26.10: passdocker build .: pass. The image reportsCoreDNS-1.14.7+k8s_gateway-0.4.0 ... go1.26.10, and-pluginslistsk8s_gateway.Impact assessment
Downtime risk: MEDIUM. The toolchain bump alone is low risk, but the critical/high vuln fixes force a big jump in the embedded CoreDNS (1.11.3 -> 1.14.7) and client-go (0.29 -> 0.35). The
goline also moves 1.21 -> 1.25, which changes GODEBUG defaults. For example: TLS 3DES/RSA key exchange removed by default, x509 negative serial numbers rejected,x509usefallbackroots/asynctimerchanbehaviour, and HTTP/2 / ServeMux pattern changes. All of these only matter if the matching plugin/feature is in use.dnsserver.Directives), so new upstream plugins are compiled in. Corefile syntax for the plugins we use (k8s_gateway, forward, cache, etc.) should be unchanged, but validate the deployed Corefile in staging before rolling to prod.golangci-lintv1.54.2 (pinned in ci.yml) predates Go 1.26 and will probably fail to load the 1.26 stdlib. The lint job may go red and need a separate golangci-lint upgrade. Unit tests are unaffected.Cert exposure: none found. No emSign/eMudhra references, no custom CertPool / RootCAs / SSL_CERT_FILE in this repo. Outbound TLS only happens if a Corefile turns on bundled CoreDNS plugins (e.g.
forward tls://, route53/clouddns/azure), and those talk to public cloud / DoT endpoints that don't chain through emSign. Kubernetes API TLS uses the in-cluster SA CA.Deploy path: a multi-arch container image (
make docker/make releaseto quay.io) via the docker/release workflows, plus goreleaser binaries on tags, plus a Helm chart incharts/. The binary is static (CGO_ENABLED=0) and the runtime staysscratch. CoreDNS is a stateless DNS server, so a rolling update with >= 2 replicas is safe. Watch DNS resolution during the rollout.The fix only takes effect after the image is rebuilt AND redeployed.
Known remaining vulnerabilities
None at critical/high. Medium/low/unknown advisories are left on purpose (out of scope).
Note
Medium Risk
Large transitive bumps (CoreDNS 1.11→1.14, client-go 0.29→0.35) and Go 1.25+ behavior changes can affect DNS plugin behavior and cluster API compatibility; rollout should be validated in staging despite minimal first-party code changes.
Overview
Upgrades the project to Go 1.26.10 (with
toolchainingo.mod) to address CVE-2026-111943, and refreshes CoreDNS (v1.14.7), client-go / k8s libs (v0.35.4), and related indirect dependencies viago.mod/go.sum.Build & CI: The main
Dockerfilenow builds ongolang:1.26.10-alpine, drops the Debian runtime stage, and copies the Alpine CA bundle into the existingscratchimage. GitHub Actions workflows use Go 1.26.10, pin third-party actions to commit SHAs, bump golangci-lint to v2.15.0 (action v9.3.0), and setcache: falseon releasesetup-gosteps.tilt.Dockerfileswitches to Alpine for certs; the kind test helper uses registry:3.Code: Informer
ListWatchhooks inkubernetes.goare migrated toListWithContextFunc/WatchFuncWithContextfor the newer client-go API. A one-line error-string casing fix ingateway.gosatisfies lint.Reviewed by Cursor Bugbot for commit 2f454c4. Bugbot is set up for automated code reviews on this repo. Configure here.