-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove l2db #29
Fix: remove l2db #29
Conversation
Agreed! It'd be great to break this PR down into multiple PRs. Separate PRs for L2Db, purger, l2tx, etc. would make it easier for reviewing and rolling back later on if something goes wrong 🙏 |
It will be time taking task to undo changes from this PR and create a new one for functions which I have already removed. I will create separate PRs for L2Tx, PoolL2tx and L2Coordinator txn later on. Please for now, review this one. Most of the removed things were already commented out, it will not take more than 20 min. Also this is a low priority task so I dont want to spend much time for both of us on it. |
okay, then how about cleaning up the migrations files in this PR |
Sure, Do you mean I should include clean up of migration files in this PR ? |
yes |
Removed basic L2 specs from migration files, but I notes there are still many things to remove from migration like auction, wdelayer, pool specs which are needed etc. Currently we have high priority task to test sync so I will create tasks for this migration removal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR contains these two tasks: https://www.notion.so/tokamak/Remove-Purger-164d96a400a38022aaacebcd45b9c9eb?pvs=4
https://www.notion.so/tokamak/Remove-L2Db-related-code-14bd96a400a380d184dada0f81ff5d0e?pvs=4
I have mostly worked on to remove L2DB, purger, some instances of L2tx and coordinator transaction from multiple files. I will create two more tickets to remove L2Tx, PoolL2 txns and L1Coordinator txns. This PR has already more than 800 changes so it will be good to divide this into multiple task and PRs. Let me your suggestions.