Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor L2 related struct and functions #41

Merged
merged 16 commits into from
Jan 7, 2025
Merged

Conversation

kaiden-araki
Copy link
Collaborator

@kaiden-araki kaiden-araki commented Jan 6, 2025

Refactor L2 related struct and functions

  • Mainly remove L2 and PoolL2 struct
  • Rename and update L2 related functions across the codebase

@kaiden-araki kaiden-araki self-assigned this Jan 6, 2025
Shailu-s
Shailu-s previously approved these changes Jan 6, 2025
Copy link
Collaborator

@Shailu-s Shailu-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

sequencer/eth/rollup.go Outdated Show resolved Hide resolved
sequencer/eth/rollup.go Outdated Show resolved Hide resolved
@Intizar-T
Copy link
Collaborator

for changes in rollup.go, the refactor branch is behind develop. I suggest making a PR merging develop into refactor first and then update changes in rollup.go. The contract function signatures have changed, which will cause conflicts down the line 🙏

Copy link
Collaborator

@Intizar-T Intizar-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kaiden-araki kaiden-araki merged commit 6512855 into refactor Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants