Implement I/O safety traits #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quininer
requested changes
Aug 18, 2022
src/util.rs
Outdated
| } else { | ||
| Err(()) | ||
| /// An owned file descriptor. | ||
| pub struct Fd(pub OwnedFd); |
There was a problem hiding this comment.
I would make io_uring use OwnedFd directly.
There was a problem hiding this comment.
What is this project's MSRV? I use the Fd wrapper to choose between OwnedFd and a version compatible with older versions of Rust. Using OwnedFd directly would bump the MSRV to 1.63.
There was a problem hiding this comment.
Don't have an explicit MSRV, but I really don't want to chase a compiler version that's too new.
We still have to provide a fallback impl, but the interface should be consistent with OwnedFd. After 1.63 is old enough, we can delete this fallback impl directly.
quininer
requested changes
Aug 23, 2022
quininer
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
io_safetyfeature that uses theAsFdtrait from Rust 1.63. In addition, theFdutility type is implemented usingOwnedFdfor its niching.See also: sunfishcode/io-lifetimes#38