Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

86 lang #88

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

86 lang #88

wants to merge 8 commits into from

Conversation

tomharrigan
Copy link
Owner

Adds support for translations of the plugin and the generated utterances

Copy link

@netaustin netaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇺🇸

throw new InvalidArgumentException( sprintf( esc_html__( "Certificate isn't in '%s' folder. Request isn't from Alexa.", 'voicewp' ), static::SIGNATURE_VALID_PATH ) );
} else if ( isset( $url['port'] ) && static::SIGNATURE_VALID_PORT !== $url['port'] ) {
/* translators: %s: port number */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that be %d


$news_utterances = array(
'Latest' => array(
esc_html__( 'can I have the latest content', 'voicewp' ),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man, that is one existential looking voice command

sprintf( esc_html__( 'Get %s stories', 'voicewp' ), $term_name_slot ),
),
'ReadPost' => array(
/* translators: %s: number */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but, ordinal number, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er, i see. being very thorough here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er, i see. being very thorough here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants