-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a semantic versioning checker #1219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
=======================================
Coverage 84.41% 84.41%
=======================================
Files 549 549
Lines 61952 61952
=======================================
Hits 52295 52295
Misses 9657 9657 ☔ View full report in Codecov by Sentry. |
I tried to cross-compile |
Ok, fixed everything |
Thank you, that's a valuable check to have. Do we want to activate it before we hit the |
It should work, it uses the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this one, thank you 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the value to know what APIs are breaking. From the docs, it appears it's used before a publish operation. I think it's also useful once we go 1.0. So it might be useful to get accustomed. |
Actually it runs perfectly comparing |
Ok then, let's try it! |
Checklist
run-checks all
script has been executed.Related Issues/PRs
A semantic versioning checker lints API changes for semver violations. Even this check will run periodically on CI not to stress a lot the entire infrastracture