Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardsigmoid formula and fix WGAN doc + default lr #2706

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 16, 2025

Changes

As discussed on discord, added at least the hard sigmoid definition. Don't think it's worth mentioning the default values for other frameworks necessarily, even the wiki page uses alpha = 0.2 (and not 1/6).

Also minor fix for WGAN doc (and improved default LR based on batch size)

@laggui laggui merged commit 9d9ea8b into main Jan 16, 2025
5 checks passed
@laggui laggui deleted the fix/somedocs branch January 16, 2025 15:07
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (f630b3b) to head (1e27b8d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2706      +/-   ##
==========================================
+ Coverage   83.20%   83.36%   +0.16%     
==========================================
  Files         819      819              
  Lines      106814   106608     -206     
==========================================
  Hits        88870    88870              
+ Misses      17944    17738     -206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant