Skip to content

Commit

Permalink
fix(crds): 🐛 bad regexp to generate CRDs release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
darkweaver87 committed Jan 10, 2025
1 parent 057783a commit 882db5c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:

- name: Render changelog configuration
env:
REGEXP: "?!crds"
REGEXP: "?!CRDs-"
run: |
export DATE=$(date +%F); cat .github/workflows/changelog.json | envsubst > /tmp/changelog.json; cat /tmp/changelog.json
if: steps.tag_exists.outputs.TAG_EXISTS == 'false'
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:

- name: Render changelog configuration
env:
REGEXP: "?!crds"
REGEXP: "CRDs"
run: |
export DATE=$(date +%F); cat .github/workflows/changelog.json | envsubst > /tmp/changelog.json; cat /tmp/changelog.json
if: steps.tag_exists.outputs.TAG_EXISTS == 'false'
Expand Down
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,15 @@ While encouraging contributions, the philosophy leads to avoid introducing:
- Dashboard exposition tuning
- Helm chart variables that shortcuts/expose static or dynamic Traefik configuration

## Commit messages

Commits messages should follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) specification and should specify a scope.

All commits will appear in traefik helm chart changelog with two exceptions:

- CRDs: CRDs are shared between traefik and traefik-crds charts, thus, commits with this scope will appear in both charts changelog (e.g. `feat(CRDs): update Traefik proxy CRDs to v3.x`)
- CRDs-.*: commits with `CRDs-` prefixed scope will appear only on traefik CRD changelog (e.g. `docs(CRDs-values: update values documentation`)

# Statistics

Once a year, [monocle](https://github.com/change-metrics/monocle) is used to gather statistics on this project.
Expand Down

0 comments on commit 882db5c

Please sign in to comment.