-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake test cases sample #3813
base: main
Are you sure you want to change the base?
Fake test cases sample #3813
Conversation
Seems like it would be easier to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly, I don't see value in this beyond testing rare/complicated edge cases.
While the integration test cases work similarly, they rely on real credentials pulled from GCP, which prevents non-Truffle members from running them locally.
There is no substitution for integration tests. GitHub Actions should run the integration tests but this has been broken for a while.
This will become helpful when we will implement the detectors as config feature I guess. |
Description:
This PR serves as a sample for new fake test cases. It helps us verify how our detector behaves when receiving specific responses from the API. While the integration test cases work similarly, they rely on real credentials pulled from GCP, which prevents non-Truffle members from running them locally.
Please review and feel free to share any ideas or suggestions in the comments! 🚀
Do not Merge ❌ unless approved by @zricethezav @ahrav @abmussani and other key members.
Checklist:
make test-community
)?make lint
this requires golangci-lint)?