Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic-usbc-devices panel was manually constructed from TSX cutouts and holes, then flattened into one
pcb_board. Existing placement checks missed four board regions whose intended tabs were removed by neighboring slots, leaving all surviving support on one side.Add
checkPcbBoardSupportto the public API andrunAllPlacementChecks(and thereforerunAllChecks). It infers straight mouse-bite rows from emitted NPTH/slot geometry, virtually separates the boards, and reports apcb_placement_errorfor regions with fewer than two surviving tabs or all attachments on one side. It also accepts nativepcb_panelenvelopes; no project-specific names or layout metadata are required.The original manufacturing geometry reports four errors (limit, toggle, dial, buzzer); the corrected carrier layout reports none. Tests cover both real exports, a native TSX panel with routed-away tabs, one-tab/detached regions, rotations and translations, readable names, record ordering, immutability, and placement-runner integration.
Scope: this is a conservative geometric check, not a load/deflection simulation. It infers straight regularly pitched small NPTH rows beside routing slots, excludes regions below 25 mm² as possible tab remnants, and does not assess V-scores or unperforated/curved tabs. Explicitly unsupported converted geometry produces a diagnostic when panel support is being assessed.
Validation: full suite (772 passing), final focused suite (15 passing), TypeScript, package build, formatting, and a Node consumer smoke test of the built API/placement runner. The fixture provenance is recorded alongside the data. The companion project correction is tscircuit/basic-usbc-devices#1.