Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a quantity column to prevent superlong BOM #415

Open
Abse2001 opened this issue Dec 23, 2024 · 9 comments · May be fixed by #443
Open

Make a quantity column to prevent superlong BOM #415

Abse2001 opened this issue Dec 23, 2024 · 9 comments · May be fixed by #443

Comments

@Abse2001
Copy link
Contributor

This is what we have now.
Image

I have this in mind. It will be clean, and we will keep track of the quantity of every part.
Image

Notice that they share the same row when there is more than one name with the same part number.

cc @seveibar

@seveibar
Copy link
Contributor

@Abse2001 i like this, we should give it a name so circuit json to bom can optionally generate in this format

For example "withMergedQuantities" or something

@karthik-nair-20
Copy link
Contributor

I wish to work on this, @Abse2001 it would be really helpful if you could assist me in reproducing this issue

@Abse2001
Copy link
Contributor Author

@karthik-nair-20 ok go to this link to open the snippet for a live example
https://tscircuit.com/editor?snippet_id=d5211bc2-835d-41cb-a10d-af0d8a04b8e0
Press RUN
Image
open the menu and go to the bill of materials
Image
you can see that we have two components with the same part number we want to combine the names like in the previous example and have a quantity column, this will be cleaner and prevent adding a row for every component with matching part numbers
Image

@Abse2001
Copy link
Contributor Author

Abse2001 commented Dec 25, 2024

@karthik-nair-20 fork both snippet and https://github.com/[tscircuit/circuit-json-to-bom-csv](https://github.com/tscircuit/circuit-json-to-bom-csv) idk how is this generated exactly so you need to check snippet how the bill of materials work and I think you need to implement in circuit-json-to-bom-csv repo you can then test your work locally with yalc
you can then use

 supplierPartNumbers={{
        jlcpcb: ["<the part number>"],
      }}

to recreate the issue just add 2 componentes with different names with the same part number
Image

@seveibar
Copy link
Contributor

/bounty $10

Copy link

algora-pbc bot commented Dec 26, 2024

💎 $10 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #415 with your implementation plan
  2. Submit work: Create a pull request including /claim #415 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/snippets!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @techmannih #443

@seveibar
Copy link
Contributor

Note: The fix is inside circuit-json-to-bom as @Abse2001 mentioned, then you have to come back here and update the dep (or to tscircuit core)

@techmannih techmannih linked a pull request Dec 29, 2024 that will close this issue
Copy link

algora-pbc bot commented Dec 29, 2024

💡 @techmannih submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@seveibar
Copy link
Contributor

This issue needs to be transferred to runframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants