Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quantity column in bills #443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

techmannih
Copy link
Contributor

@techmannih techmannih commented Dec 29, 2024

fix #415
/claim #415

@techmannih
Copy link
Contributor Author

@seveibar please review this

@seveibar
Copy link
Contributor

Can you make a playwright test that snapshots the BOM tab content on a representative page?

@seveibar
Copy link
Contributor

Also this fix is in the wrong repo, we're migrating to runframe, so youll need to make the change there, you can close this

@techmannih
Copy link
Contributor Author

techmannih commented Dec 30, 2024

Also this fix is in the wrong repo, we're migrating to runframe, so youll need to make the change there, you can close this

@seveibar correct, I think need to fix it in "circuit-json-to-pnp-csv" repo, and also need a PR in this repo for displaying it. please confirm if I am correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a quantity column to prevent superlong BOM
2 participants