fix dialog background colors #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should one mix "dark" with "dark" for a dialog? Shouldn't a dialog stand out? |
Generally I think yes, but people using the black theme often do so to save battery and then it is better if it is as dark as possible 🤷 |
Tak
approved these changes
Jan 14, 2025
connyduck
added a commit
that referenced
this pull request
Jan 16, 2025
In #4851 I changed the theme of `AccountsInListFragment`, which accidentally turned its background white for the dark theme. Additionally this fixes the color for the preference dialogs, which I think have been incorrect since the Material3 redesign. I also wondered if we should make dialogs darker for the black theme, but looks like there is not much interest in that https://chaos.social/deck/@ConnyDuck/113802937491059461 (Currently they are just the same as the dark theme)
Merged
connyduck
added a commit
that referenced
this pull request
Jan 17, 2025
Let's get those three fixes out. #4864 is the important one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4851 I changed the theme of
AccountsInListFragment, which accidentally turned its background white for the dark theme.Additionally this fixes the color for the preference dialogs, which I think have been incorrect since the Material3 redesign.
I also wondered if we should make dialogs darker for the black theme, but looks like there is not much interest in that https://chaos.social/deck/@ConnyDuck/113802937491059461
(Currently they are just the same as the dark theme)