Repository navigation
Conversation
mdo
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
|
Reviewing this PR months after the last one. The context seems clearer to me right now. I took the liberty to add a commit to handle new things mentionned in the issue. Feel free to debate or revert 72ee1af. My proposal here is to display the placeholder once the input is focused and try to better the solution to make it applicable on each scale. |
julien-deramond
added
the
has-conflicts
julien-deramond
force-pushed
the
floating-always-visible
branch
from
September 4, 2025 20:29
d2da6e5 to
72ee1af
Compare
julien-deramond
removed
the
has-conflicts
Member
|
I haven't reviewed the PR but I did the following to help moving forward with it:
|
Member
Author
|
Modernized for v6 in #42833 (tokens, label-first |
mdo
added a commit
that referenced
this pull request
Sep 29, 2026
* fix(forms): always float labels on date and time inputs Date, time, datetime-local, month, and week inputs do not support placeholders like text fields, so floating labels looked filled even when empty and padding stayed inconsistent. Keep those controls (and selects) in the floated label and padding state, and document the behavior. Fixes #39257 * fix(forms): mute date/time separators and dedupe docs Date and time inputs show hard `/` and `:` dividers that fight the control’s muted placeholder look in WebKit and Blink. Color those separators with the control placeholder token, and fold the duplicate date and time docs section into one. * feat(forms): add always-floating labels for v6 Port the always-visible floating label opt-in from #36155 to the v6 token and label-first :has() model. Show placeholders on focus by default, and add .form-floating-always to keep the label floated with a visible placeholder. Supersedes #36155 * fix(forms): pass floating label CI checks Use lint-compatible date, time, and select selectors while preserving their matches. Raise the minified CSS budget to cover the new floating label rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36026.
Needs another pass to see if there's another selector I can use instead of a modifier class, but for now I think an explicit opt-in for this is the best route.