Repository navigation
Bump skrifa to 0.48 and write-fonts to 0.54 - #38
Open
gastongouron wants to merge 1 commit into
Open
gastongouron wants to merge 1 commit into
gastongouron wants to merge 1 commit into
Conversation
This was referenced Oct 23, 2026
|
Thanks for this! skrifa 0.49 and write-fonts 0.55 were released on October 21 and use read-fonts 0.46, the same version as HarfRust 0.15, so bumping one step further would let subsetter share a single read-fonts with current HarfRust and skrifa users. It needs no code changes either; I tried it on top of main: yhay81@1fca778
Would you like to update this PR to those versions? If you'd rather keep it as is, I can open a follow-up PR after this one is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps skrifa 0.42 -> 0.48 and write-fonts 0.48 -> 0.54 (read-fonts 0.45 underneath), plus the matching dev-dependency and the fuzz crate. kurbo 0.13 is still what write-fonts 0.54 wants, so it stays.
Motivation: subsetter is now the only crate in our tree still on skrifa 0.42. resvg/usvg moved to 0.44 and harfrust is on read-fonts 0.41, so anything that subsets with this crate and renders with those ends up compiling two fontations stacks. Getting subsetter onto current skrifa lets the rest of the ecosystem share one.
No code changes were needed. Checked locally:
cargo testwith fonttools on PATH: 175 passed, same result as before the bumpcargo clippy --workspace --all-targets --all-featuresandcargo fmt --check --allcleancargo check --workspaceon 1.85.0 (fontations crates declare rust-version 1.85, so the MSRV holds)