Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IndexConfig.create() static #36

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Make IndexConfig.create() static #36

merged 1 commit into from
Oct 31, 2023

Conversation

tzaeschke
Copy link
Owner

Fix for issue #35.

@tzaeschke tzaeschke self-assigned this Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15e1973) 73.61% compared to head (9d2fc6c) 73.76%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
+ Coverage     73.61%   73.76%   +0.14%     
- Complexity     2046     2053       +7     
============================================
  Files            76       76              
  Lines          8058     8058              
  Branches       1575     1575              
============================================
+ Hits           5932     5944      +12     
+ Misses         1738     1727      -11     
+ Partials        388      387       -1     
Files Coverage Δ
src/main/java/org/tinspin/index/IndexConfig.java 83.33% <50.00%> (+83.33%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke merged commit bfb9572 into master Oct 31, 2023
2 of 3 checks passed
@tzaeschke tzaeschke deleted the fix/35-static-create branch October 31, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant