Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #40 fixes #41

Merged
merged 6 commits into from
Jun 22, 2024
Merged

Issue #40 fixes #41

merged 6 commits into from
Jun 22, 2024

Conversation

tzaeschke
Copy link
Owner

The test provided in issue #40 (for a possible ArrayOutOfBoundsException) revealed a number of problems related to removing and inserting entries. This PR is a cumulative fix for these.

@tzaeschke tzaeschke self-assigned this Jun 13, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 59.18367% with 20 lines in your changes missing coverage. Please review.

Project coverage is 75.10%. Comparing base (fc9e7fd) to head (fb7761e).

Current head fb7761e differs from pull request most recent head 46bd1c7

Please upload reports for the commit 46bd1c7 to get more accurate results.

Files Patch % Lines
...ain/java/org/tinspin/index/qthypercube2/QNode.java 57.44% 17 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
+ Coverage     74.77%   75.10%   +0.32%     
- Complexity     2084     2113      +29     
============================================
  Files            76       76              
  Lines          8061     8090      +29     
  Branches       1576     1581       +5     
============================================
+ Hits           6028     6076      +48     
+ Misses         1644     1617      -27     
- Partials        389      397       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke merged commit 5d06b16 into master Jun 22, 2024
1 check passed
@tzaeschke tzaeschke deleted the fix/40-undersized-node-after-remove branch June 22, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant