Repository navigation
Conversation
mvnw.cmd and .mvn/wrapper/maven-wrapper.properties have no Apereo header, so license:check fails. The parent jasig-release profile binds that check at validate, so release:prepare/perform fail too. Exclude the wrapper files (mvnw, mvnw.cmd, .mvn/**).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Maven Wrapper pass added
mvnw.cmdand.mvn/wrapper/maven-wrapper.properties, which carry the Apache wrapper header rather than the Apereo one.license:checkmaps.cmdand.propertiesfiles, so it fails on both (mvnwhas no extension and is skipped).CI doesn't notice, because it runs plain
package. Butuportal-portlet-parent'sjasig-releaseprofile bindslicense:checkatvalidate, andmaven-release-pluginactivates that profile, sorelease:prepare/release:performfail immediately. Where there's arelease-portlet.sh, itslicense:formatstep would rewrite the wrapper files and abort on drift.Change
mvnw,mvnw.cmdand.mvn/**to the parent's excludes (combine.children="append", so the parent list still applies).Verification
./mvnw -B license:checkon this branch: BUILD SUCCESS, also with a stray file underoverlays/present. Onmasterit fails on the two wrapper files../mvnw -B -Pjasig-release validatenow gets pastlicense:check, then failsnotice:check(NOTICE out of date). That failure is pre-existing onmasterand unrelated;notice:generatebefore releasing fixes it.Notes
uportal-portlet-parentas the default, but repos need this local change now to release, and repos whose<excludes>replace the parent's list wouldn't pick up a parent-only change anyway.