Skip to content

build(license): exclude Maven Wrapper files from the license check - #294

Open
Naenyn wants to merge 1 commit into
uPortal-Project:masterfrom
Naenyn:build/license-exclude-wrapper
Open

Naenyn wants to merge 1 commit into
uPortal-Project:masterfrom
Naenyn:build/license-exclude-wrapper

Conversation

@Naenyn

@Naenyn Naenyn commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Problem

The Maven Wrapper pass added mvnw.cmd and .mvn/wrapper/maven-wrapper.properties, which carry the Apache wrapper header rather than the Apereo one. license:check maps .cmd and .properties files, so it fails on both (mvnw has no extension and is skipped).

CI doesn't notice, because it runs plain package. But uportal-portlet-parent's jasig-release profile binds license:check at validate, and maven-release-plugin activates that profile, so release:prepare / release:perform fail immediately. Where there's a release-portlet.sh, its license:format step would rewrite the wrapper files and abort on drift.

Change

  • This repo had no local license-plugin config. Add a minimal block that appends mvnw, mvnw.cmd and .mvn/** to the parent's excludes (combine.children="append", so the parent list still applies).

Verification

  • ./mvnw -B license:check on this branch: BUILD SUCCESS, also with a stray file under overlays/ present. On master it fails on the two wrapper files.
  • ./mvnw -B -Pjasig-release validate now gets past license:check, then fails notice:check (NOTICE out of date). That failure is pre-existing on master and unrelated; notice:generate before releasing fixes it.

Notes

  • Part of a fleet-wide fix for the wrapper pass. The same excludes are also going into uportal-portlet-parent as the default, but repos need this local change now to release, and repos whose <excludes> replace the parent's list wouldn't pick up a parent-only change anyway.

mvnw.cmd and .mvn/wrapper/maven-wrapper.properties have no Apereo
header, so license:check fails. The parent jasig-release profile binds
that check at validate, so release:prepare/perform fail too. Exclude
the wrapper files (mvnw, mvnw.cmd, .mvn/**).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant