Skip to content

Commit

Permalink
Gradle upgrade (#2612)
Browse files Browse the repository at this point in the history
* AnalyticsEvent capture additional data, support query

* delete extra files

* update query for event_type

* fix serialization error for to event properties

* perform endpoint authentication

* remove ipaddress from AnalyticsPortalEvent

* build.gradle changes compile to implementation started

* added java-library plugin, replaced some compile with api

* additional conversion from compile to implementation or api

* more updates from compile to implementation and api

* additional migration from compile to implementation and api

* migrated remaining compile to implementation and api

* replace deprecated runtime with runtimeOnly

* resolve merge conflicts

Co-authored-by: Michael Gillian <[email protected]>
Co-authored-by: Benito Gonzalez <[email protected]>
  • Loading branch information
3 people authored Jan 15, 2023
1 parent fc0b8ef commit b542fce
Show file tree
Hide file tree
Showing 46 changed files with 306 additions and 305 deletions.
13 changes: 7 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ node {

allprojects {
apply plugin: 'java'
apply plugin: 'java-library'
apply plugin: 'jacoco'
apply plugin: 'eclipse'
apply plugin: 'com.github.spotbugs'
Expand Down Expand Up @@ -115,12 +116,12 @@ subprojects {
}

dependencies {
testCompile "junit:junit:${junitVersion}"
testCompile "org.easymock:easymock:${easymockVersion}"
testCompile "org.hamcrest:hamcrest-all:${hamcrestVersion}"
testCompile "org.mockito:mockito-core:${mockitoVersion}"
testCompile "org.springframework:spring-test:${springVersion}"
testCompile "org.xmlunit:xmlunit-legacy:${xmlunitVersion}"
testImplementation "junit:junit:${junitVersion}"
testImplementation "org.easymock:easymock:${easymockVersion}"
testImplementation "org.hamcrest:hamcrest-all:${hamcrestVersion}"
testImplementation "org.mockito:mockito-core:${mockitoVersion}"
testImplementation "org.springframework:spring-test:${springVersion}"
testImplementation "org.xmlunit:xmlunit-legacy:${xmlunitVersion}"
spotbugsPlugins 'com.h3xstream.findsecbugs:findsecbugs-plugin:1.12.0'
}

Expand Down
14 changes: 7 additions & 7 deletions uPortal-api/uPortal-api-internal/build.gradle
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
description = "Apereo uPortal Internal API"

dependencies {
compile project(':uPortal-io:uPortal-io-jaxb')
compile project(':uPortal-layout:uPortal-layout-core')
compile project(':uPortal-marketplace')
compile project(':uPortal-persondir')
compile project(':uPortal-rendering')
compile project(':uPortal-security:uPortal-security-services')
implementation project(':uPortal-io:uPortal-io-jaxb')
implementation project(':uPortal-layout:uPortal-layout-core')
implementation project(':uPortal-marketplace')
implementation project(':uPortal-persondir')
implementation project(':uPortal-rendering')
api project(':uPortal-security:uPortal-security-services')

compileOnly "${portletApiDependency}"
compileOnly "${servletApiDependency}"

compileOnly "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
testCompile "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
testImplementation "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
}
30 changes: 15 additions & 15 deletions uPortal-api/uPortal-api-rest/build.gradle
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
description = "Apereo uPortal REST APIs"

dependencies {
compile project(':uPortal-groups:uPortal-groups-pags')
compile project(':uPortal-index')
compile project(':uPortal-layout:uPortal-layout-impl')
compile project(':uPortal-security:uPortal-security-permissions')
implementation project(':uPortal-groups:uPortal-groups-pags')
implementation project(':uPortal-index')
implementation project(':uPortal-layout:uPortal-layout-impl')
api project(':uPortal-security:uPortal-security-permissions')
compileOnly "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"

compile "commons-beanutils:commons-beanutils:${commonsBeanutilsVersion}"
compile "io.springfox:springfox-swagger2:${springfoxSwaggerVersion}"
compile "io.springfox:springfox-swagger-ui:${springfoxSwaggerVersion}"
compile "org.apache.lucene:lucene-queryparser:${luceneVersion}"
compile "org.json:json:${orgJsonVersion}"
compile "org.slf4j:slf4j-api:${slf4jVersion}"
implementation "commons-beanutils:commons-beanutils:${commonsBeanutilsVersion}"
implementation "io.springfox:springfox-swagger2:${springfoxSwaggerVersion}"
implementation "io.springfox:springfox-swagger-ui:${springfoxSwaggerVersion}"
implementation "org.apache.lucene:lucene-queryparser:${luceneVersion}"
implementation "org.json:json:${orgJsonVersion}"
implementation "org.slf4j:slf4j-api:${slf4jVersion}"
compileOnly "org.projectlombok:lombok:${lombokVersion}"
annotationProcessor "org.projectlombok:lombok:${lombokVersion}"

compileOnly "${portletApiDependency}"
compileOnly "${servletApiDependency}"

testCompile "${servletApiDependency}"
testCompile "${portletApiDependency}"
testImplementation "${servletApiDependency}"
testImplementation "${portletApiDependency}"
//need to add for SessionRESTControllerTest.java
testCompile "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
testCompile "org.mockito:mockito-inline:${mockitoVersion}"
testCompile project(':uPortal-security:uPortal-security-permissions')
testImplementation "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
testImplementation "org.mockito:mockito-inline:${mockitoVersion}"
testImplementation project(':uPortal-security:uPortal-security-permissions')
}
6 changes: 3 additions & 3 deletions uPortal-concurrency/build.gradle
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
description = "Apereo uPortal Concurrency"

dependencies {
compile project(':uPortal-core')
api project(':uPortal-core')

compile "com.google.guava:guava:${guavaVersion}"
compile "org.springframework:spring-web:${springVersion}"
implementation "com.google.guava:guava:${guavaVersion}"
implementation "org.springframework:spring-web:${springVersion}"

}
6 changes: 3 additions & 3 deletions uPortal-content/uPortal-content-portlet/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ ext {
}

dependencies {
compile project(':uPortal-layout:uPortal-layout-core')
compile project(':uPortal-rdbm')
api project(':uPortal-layout:uPortal-layout-core')
implementation project(':uPortal-rdbm')

compileOnly "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
annotationProcessor "org.hibernate:hibernate-jpamodelgen:${hibernateJpamodelgenVersion}"
compileOnly "${portletApiDependency}"
compileOnly "${servletApiDependency}"

testCompile "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
testImplementation "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
}

/*
Expand Down
6 changes: 3 additions & 3 deletions uPortal-content/uPortal-content-publishing/build.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description = "Apereo uPortal Content Publishing"

dependencies {
compile project(':uPortal-content:uPortal-content-portlet')
compile project(':uPortal-io:uPortal-io-jaxb')
compile project(':uPortal-utils:uPortal-utils-core')
implementation project(':uPortal-content:uPortal-content-portlet')
implementation project(':uPortal-io:uPortal-io-jaxb')
implementation project(':uPortal-utils:uPortal-utils-core')
}
28 changes: 14 additions & 14 deletions uPortal-core/build.gradle
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
description = "Apereo uPortal Core"

dependencies {
compile("com.googlecode.ehcache-spring-annotations:ehcache-spring-annotations:${ehcacheSpringAnnotationsVersion}") {
api("com.googlecode.ehcache-spring-annotations:ehcache-spring-annotations:${ehcacheSpringAnnotationsVersion}") {
exclude group: 'com.google.guava', module: 'guava'
}
compile 'javax.annotation:javax.annotation-api:1.3.2'
compile "commons-lang:commons-lang:${commonsLangVersion}"
compile "joda-time:joda-time:${jodaTimeVersion}"
compile "org.apache.commons:commons-lang3:${commonsLang3Version}"
compile "org.hibernate:hibernate-core:${hibernateVersion}"
compile("org.jadira.usertype:usertype.core:${usertypeVersion}") {
api 'javax.annotation:javax.annotation-api:1.3.2'
api "commons-lang:commons-lang:${commonsLangVersion}"
api "joda-time:joda-time:${jodaTimeVersion}"
api "org.apache.commons:commons-lang3:${commonsLang3Version}"
api "org.hibernate:hibernate-core:${hibernateVersion}"
api("org.jadira.usertype:usertype.core:${usertypeVersion}") {
exclude group: 'org.hibernate', module: 'hibernate-core'
exclude group: 'org.hibernate', module: 'hibernate-entitymanager'
}
compile "org.jadira.usertype:usertype.spi:${usertypeVersion}"
compile "org.slf4j:log4j-over-slf4j:${slf4jVersion}"
compile "org.slf4j:jcl-over-slf4j:${slf4jVersion}"
compile "org.slf4j:slf4j-api:${slf4jVersion}"
compile "org.springframework:spring-context:${springVersion}"
compile "org.springframework:spring-jdbc:${springVersion}"
compile "org.springframework.security:spring-security-core:${springSecurityVersion}"
api "org.jadira.usertype:usertype.spi:${usertypeVersion}"
implementation "org.slf4j:log4j-over-slf4j:${slf4jVersion}"
implementation "org.slf4j:jcl-over-slf4j:${slf4jVersion}"
implementation "org.slf4j:slf4j-api:${slf4jVersion}"
implementation "org.springframework:spring-context:${springVersion}"
implementation "org.springframework:spring-jdbc:${springVersion}"
implementation "org.springframework.security:spring-security-core:${springSecurityVersion}"

compileOnly "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
compileOnly "${portletApiDependency}"
Expand Down
8 changes: 4 additions & 4 deletions uPortal-events/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ ext {
}

dependencies {
compile project(':uPortal-rendering')
compile project(':uPortal-security:uPortal-security-core')
api project(':uPortal-rendering')
api project(':uPortal-security:uPortal-security-core')

compile "org.apache.commons:commons-math3:${commonsMath3Version}"
implementation "org.apache.commons:commons-math3:${commonsMath3Version}"
// NOTE: String that the group and version don't seem to
// match, but apparently this version is correct.
compile "org.apache.httpcomponents:httpclient:${httpclientVersion}"
implementation "org.apache.httpcomponents:httpclient:${httpclientVersion}"

compileOnly "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
annotationProcessor "org.hibernate:hibernate-jpamodelgen:${hibernateJpamodelgenVersion}"
Expand Down
6 changes: 3 additions & 3 deletions uPortal-groups/uPortal-groups-core/build.gradle
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
description = "Apereo uPortal Groups Core"

dependencies {
compile project(':uPortal-content:uPortal-content-portlet')
compile project(':uPortal-rdbm')
api project(':uPortal-content:uPortal-content-portlet')
implementation project(':uPortal-rdbm')

compile "com.google.guava:guava:${guavaVersion}"
implementation "com.google.guava:guava:${guavaVersion}"

compileOnly "${servletApiDependency}"
}
2 changes: 1 addition & 1 deletion uPortal-groups/uPortal-groups-filesystem/build.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description = "Apereo uPortal Groups Filesystem"

dependencies {
compile project(':uPortal-groups:uPortal-groups-core')
implementation project(':uPortal-groups:uPortal-groups-core')

// compile "commons-io:commons-io:${commonsIoVersion}"
}
4 changes: 2 additions & 2 deletions uPortal-groups/uPortal-groups-grouper/build.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description = "Apereo uPortal Groups Grouper"

dependencies {
compile project(':uPortal-groups:uPortal-groups-core')
implementation project(':uPortal-groups:uPortal-groups-core')

compile "edu.internet2.middleware.grouper:grouperClient:${grouperClientVersion}"
implementation "edu.internet2.middleware.grouper:grouperClient:${grouperClientVersion}"
}
6 changes: 3 additions & 3 deletions uPortal-groups/uPortal-groups-ldap/build.gradle
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
description = "Apereo uPortal Groups LDAP"

dependencies {
compile project(':uPortal-groups:uPortal-groups-core')
implementation project(':uPortal-groups:uPortal-groups-core')

compile "org.springframework.ldap:spring-ldap-core:${springLdapVersion}"
compile "org.springframework.ldap:spring-ldap-core-tiger:${springLdapVersion}"
implementation "org.springframework.ldap:spring-ldap-core:${springLdapVersion}"
implementation "org.springframework.ldap:spring-ldap-core-tiger:${springLdapVersion}"
}
2 changes: 1 addition & 1 deletion uPortal-groups/uPortal-groups-local/build.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description = "Apereo uPortal Groups Local"

dependencies {
compile project(':uPortal-groups:uPortal-groups-core')
implementation project(':uPortal-groups:uPortal-groups-core')

// compile "commons-io:commons-io:${commonsIoVersion}"
}
14 changes: 7 additions & 7 deletions uPortal-groups/uPortal-groups-pags/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ ext {
}

dependencies {
compile project(':uPortal-groups:uPortal-groups-core')
compile project(':uPortal-layout:uPortal-layout-core')
compile project(':uPortal-security:uPortal-security-core')
compile project(':uPortal-url')
implementation project(':uPortal-groups:uPortal-groups-core')
implementation project(':uPortal-layout:uPortal-layout-core')
api project(':uPortal-security:uPortal-security-core')
implementation project(':uPortal-url')

compile "com.fasterxml.jackson.core:jackson-annotations:${jacksonVersion}"
compile "com.fasterxml.jackson.core:jackson-core:${jacksonVersion}"
compile "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}"
implementation "com.fasterxml.jackson.core:jackson-annotations:${jacksonVersion}"
implementation "com.fasterxml.jackson.core:jackson-core:${jacksonVersion}"
implementation "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}"

annotationProcessor "org.hibernate:hibernate-jpamodelgen:${hibernateJpamodelgenVersion}"
compileOnly "${servletApiDependency}"
Expand Down
6 changes: 3 additions & 3 deletions uPortal-groups/uPortal-groups-smartldap/build.gradle
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
description = "Apereo uPortal Groups SmartLdap"

dependencies {
compile project(':uPortal-groups:uPortal-groups-core')
implementation project(':uPortal-groups:uPortal-groups-core')

compile("com.googlecode.cernunnos:cernunnos:${cernunnosVersion}") {
implementation("com.googlecode.cernunnos:cernunnos:${cernunnosVersion}") {
exclude group: 'org.netbeans.lib', module: 'cvsclient'
exclude group: 'org.springframework', module: 'spring'
exclude group: 'net.sf.retrotranslator', module: 'retrotranslator-runtime'
Expand All @@ -17,5 +17,5 @@ dependencies {
exclude group: 'javax.script', module: 'groovy-engine'
exclude group: 'javax.script', module: 'script-api'
}
compile "org.springframework.ldap:spring-ldap-core:${springLdapVersion}"
implementation "org.springframework.ldap:spring-ldap-core:${springLdapVersion}"
}
2 changes: 1 addition & 1 deletion uPortal-health/build.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description = "Apereo uPortal Health Check"

dependencies {
compile project(':uPortal-spring')
implementation project(':uPortal-spring')

compileOnly "${servletApiDependency}"
}
8 changes: 4 additions & 4 deletions uPortal-hibernate/build.gradle
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
description = "Apereo uPortal Hibernate Utilities"

dependencies {
compile "commons-lang:commons-lang:${commonsLangVersion}"
compile "net.sf.ehcache:ehcache-core:${ehcacheVersion}"
compile "org.hibernate:hibernate-core:${hibernateVersion}"
compile "org.hibernate:hibernate-ehcache:${hibernateVersion}"
implementation "commons-lang:commons-lang:${commonsLangVersion}"
implementation "net.sf.ehcache:ehcache-core:${ehcacheVersion}"
implementation "org.hibernate:hibernate-core:${hibernateVersion}"
implementation "org.hibernate:hibernate-ehcache:${hibernateVersion}"
}
4 changes: 2 additions & 2 deletions uPortal-i18n/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ ext {
}

dependencies {
compile project(':uPortal-rdbm')
api project(':uPortal-rdbm')

compile "org.slf4j:log4j-over-slf4j:${slf4jVersion}"
implementation "org.slf4j:log4j-over-slf4j:${slf4jVersion}"

annotationProcessor "org.hibernate:hibernate-jpamodelgen:${hibernateJpamodelgenVersion}"
compileOnly "${servletApiDependency}"
Expand Down
10 changes: 5 additions & 5 deletions uPortal-index/build.gradle
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
description = "Apereo uPortal Search Indexing"

dependencies {
compile project(':uPortal-content:uPortal-content-portlet')
implementation project(':uPortal-content:uPortal-content-portlet')

compile "org.apache.lucene:lucene-core:${luceneVersion}"
compile "org.jsoup:jsoup:${jsoupVersion}"
implementation "org.apache.lucene:lucene-core:${luceneVersion}"
implementation "org.jsoup:jsoup:${jsoupVersion}"

compileOnly "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
compileOnly "${servletApiDependency}"

testCompile "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
testCompile "${servletApiDependency}"
testImplementation "org.apache.portals.pluto:pluto-container-api:${plutoVersion}"
testImplementation "${servletApiDependency}"
}
12 changes: 6 additions & 6 deletions uPortal-io/uPortal-io-core/build.gradle
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
description = "Apereo uPortal Import/Export Core"

dependencies {
compile project(':uPortal-utils:uPortal-utils-core')
implementation project(':uPortal-utils:uPortal-utils-core')

compile "commons-lang:commons-lang:${commonsLangVersion}"
compile "org.apache.commons:commons-compress:${commonsCompressVersion}"
compile "org.apache.tika:tika-core:${tikaVersion}"
compile "org.slf4j:slf4j-api:${slf4jVersion}"
compile "org.springframework:spring-oxm:${springVersion}"
implementation "commons-lang:commons-lang:${commonsLangVersion}"
implementation "org.apache.commons:commons-compress:${commonsCompressVersion}"
implementation "org.apache.tika:tika-core:${tikaVersion}"
implementation "org.slf4j:slf4j-api:${slf4jVersion}"
api "org.springframework:spring-oxm:${springVersion}"
}
14 changes: 7 additions & 7 deletions uPortal-io/uPortal-io-types/build.gradle
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
description = "Apereo uPortal Import/Export Data Types"

dependencies {
compile project(':uPortal-events')
compile project(':uPortal-groups:uPortal-groups-pags')
compile project(':uPortal-io:uPortal-io-core')
compile project(':uPortal-io:uPortal-io-jaxb')
compile project(':uPortal-security:uPortal-security-permissions')
implementation project(':uPortal-events')
api project(':uPortal-groups:uPortal-groups-pags')
implementation project(':uPortal-io:uPortal-io-core')
implementation project(':uPortal-io:uPortal-io-jaxb')
api project(':uPortal-security:uPortal-security-permissions')

compile "com.fasterxml.staxmate:staxmate:${staxmateVersion}"
compile("com.googlecode.cernunnos:cernunnos:${cernunnosVersion}") {
implementation "com.fasterxml.staxmate:staxmate:${staxmateVersion}"
api("com.googlecode.cernunnos:cernunnos:${cernunnosVersion}") {
exclude group: 'org.netbeans.lib', module: 'cvsclient'
exclude group: 'org.springframework', module: 'spring'
exclude group: 'net.sf.retrotranslator', module: 'retrotranslator-runtime'
Expand Down
Loading

0 comments on commit b542fce

Please sign in to comment.