This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
Number of small changes/optimisations #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix issue with Example app not reloading the table view first time with Contacts access permission is not given to the app. 2. Added `+new` function as NS_UNAVAILABLE in OHABAddressBookContactsDataProvider and OHCNContactsDataProvider 3. Removed compiler warning in OHSMSPicker 4. Removed unwanted _Nonnull in extern declarations as the header function already declares NS_ASSUME_NONNULL_BEGIN/NS_ASSUME_NONNULL_END
|
|
NickEntin
reviewed
May 10, 2017
| @@ -49,6 +49,8 @@ NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| - (instancetype)init NS_UNAVAILABLE; | |||
|
|
|||
| + (OHABAddressBookContactsDataProvider *)new NS_UNAVAILABLE; | |||
There was a problem hiding this comment.
Seems like a good idea, but should be done to all or none of the classes with unavailable inits. Let's make this change a separate PR since it spans a large number of files (I see 12 from a quick search). Also for consistency we should probably make it + (instancetype)new NS_UNAVAILABLE;.
There was a problem hiding this comment.
Sure @NickEntin, I'll create new PR for adding + (instancetype)new NS_UNAVAILABLE;
1. Move reloadData inside dispatch_async block to ensure the UI is updated every time user grants permission to access contacts 2. Remove +new as its part of other PR (uber-archive#50) 3. Remove unwanted inclusion of #import <OCMock/OCMock.h> from test classes 4. Remove unused setup functions from test class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+newfunction as NS_UNAVAILABLE in OHABAddressBookContactsDataProvider and OHCNContactsDataProvider