WIP 0.20 #295

jc-fireball · 2015-11-07T00:33:31Z

This release will need to wait 4-6 weeks to go out so that 0.18 can sink-in and and people have plenty of time to move to tchannel.thrift.load.

Removing Deprecated Functionality

remove client_for - Remove client_for #259
remove thrift_request_builder - Remove thrift_request_builder #264
update migration guide to move users to thrift.load
remove tchannel.tornado.TChannel.register

Remove Apache Thrift Support

remove testing.data.generated - Remove tests.data.generated #265
update tests to not test apache thrift
Delete ThriftRequest in favor of ThriftRWRequest (possibly rename the latter)
Delete ThriftSerializer in favor of ThriftRWSerializer (possibly rename the latter)
Delete Apache Thrift endpoint registration code.
lint config should not consider generated code no more generated code to ignore #274
Add "Removing Apache Thrift Support" to the top of the changelog. - add a note about removing apache thrift support #275

New Functionality

public event api (use new req/res objs, resp timer, content size)
mocking test helpers (we already have a recorder for integration tests)
customizable request context (customizable request context #145, add request context information to GUIDE and docs #143)
TChannel.register should just be "raw" endpoints (not as: raw) that receive the raw bytes, parse them manually as required, and return raw bytes in the Response. We should be able to refactor TChannel.{thrift,raw,json}.register to wrap around this.

Performance

fix event hooks not firing immediately potential delay between recieving a response and firing event hooks #285

Make peer selection fast. Currently it's taking a lot more time than it should. See:

Function	Samples	Percentage
tchannel/tornado/peer.py:connections (70ms)	1753	17.8%
tchannel/tornado/peer.py:choose (403ms)	1421	14.4%
tchannel/tornado/peer.py:score (189ms)	1074	10.9%
tchannel/tornado/peer.py:connected (105ms)	1003	10.2%
tchannel/tornado/peer.py:get (71ms)	644	6.5%

This is partly fixed by Improve peer selection performance #276.

In Preperation for 1.0

remove explicit dep on futures - remove explicit dep on futures #260
cut thriftrw 1.0 and update setup.py to <=1,>2
remove argstreams
fix lint problems in setup.py, add setup.py to lint - resolve lint issues in setup.py #271

Remove client_for

Remove thrift_request_builder

Remove tests.data.generated

remove explicit dep on futures

Now that Apache Thrift is no longer supported, we don't need two different implementations of ThriftRequest and ThriftSerializer.

thriftrw only supports the new TChannel interface. This assertion will ensure we don't accidentally call the deprecated version with Thrift endpoints and get cryptic messages.

Collapse Thrift*Request and Thrift*Serializer

Prevent all tests from using thrift code generation

Limit the size of arg1 to 16 KB

Separate handler for call req and call req continue message.

Remove assertion for connection close instead throwing StreamClosedError

because Grayson doesn't know how to

use thriftrw >=1<2

abhinav · 2015-11-09T23:04:47Z

Some tasks were punted. Closing this PR in favor of #298.

HelloGrayson and others added 30 commits October 20, 2015 12:49

start 0.19 changelog

7f32c4b

remove tchannel.sync.thrift.client_for

5f670e9

remove tchannel.thrift.client_for

1427936

changelog for removing client_for

910fcc2

Merge pull request #259 from uber/remove_client_for

54fb215

Remove client_for

remove thrift_request_builder

4653a2d

remove thrift_request_builder from thrift scheme tests

1e68b68

update mock_server to use thriftrw

bace2d6

update vcr tests to remove thrift_request_builder dep

932113a

tests passing without thrift_request_builder

1ef8620

fix fn defined but never used

3ab0b2a

changelog

1ec1ecd

Merge pull request #264 from uber/delete_thrift_request_builder

bf4aecf

Remove thrift_request_builder

remove generated thrift test classes

946141e

remove useless test

518abc1

Merge pull request #265 from uber/remove_thrift_generated_code

9c4af94

Remove tests.data.generated

remove explicit dep on futures

29aa4f7

move futures to requirements-test.txt, from setup.py

319e80e

Merge pull request #260 from uber/remove_futures_dep

005494f

remove explicit dep on futures

Collapse Thrift*Request and THrift*Serializer.

24138f2

Now that Apache Thrift is no longer supported, we don't need two different implementations of ThriftRequest and ThriftSerializer.

Assert that deprecated TChannel is not called with thrift endpoints

6a925d7

thriftrw only supports the new TChannel interface. This assertion will ensure we don't accidentally call the deprecated version with Thrift endpoints and get cryptic messages.

Move ThriftRequest to tchannel.thrift.rw

ac4e086

flake

35f7f14

Merge pull request #267 from uber/rm-thrift-req

23d47fb

Collapse Thrift*Request and Thrift*Serializer

Prevent all tests from using thrift code generation

ecafe76

Merge pull request #268 from uber/delete-thrift-test

69524b6

Prevent all tests from using thrift code generation

Makefile targets to thrift --gen are no longer needed

58301b4

reduce zipkin failures to warnings

7aaf962

preserve trace

3340d23

Merge branch '0.19.0' of github.com:uber/tchannel-python into warn19

2d48598

jc-fireball and others added 19 commits October 29, 2015 16:17

Limit the size of endpoint , assume endpoint can fit in arg1

07d9ee3

add limitation check on the client side.

5a903ac

Add more test on the server side for limit of arg1

305d6d3

address bryce's comment

61a2adf

Improve the log message

149a00d

Merge pull request #283 from uber/arg1

d6e1a0a

Limit the size of arg1 to 16 KB

WIP

e767d8e

Separate handler for call request and call request continue message

fa47144

move _HANLDER to class variable

87fb8df

update dispatch handler test for better test coverage

b37a12a

fix minor nit

89aeb2a

Merge pull request #287 from uber/handler

86c764d

Separate handler for call req and call req continue message.

Remove assertion for connection close instead throwing StreamClosedError

42d78c8

update connection test

6947caa

change the exception variable name

8d1dfd9

Add streamclosederror catpure around stream.connect

30c4d72

add change log

ab0c20a

Fix changelog formatting.

4012b26

Merge pull request #291 from uber/closed

9a88a00

Remove assertion for connection close instead throwing StreamClosedError

HelloGrayson changed the title ~~WIP 0.20 branch~~ WIP 0.20 Nov 7, 2015

HelloGrayson and others added 5 commits November 6, 2015 17:13

merge master

4ebc1f2

use thriftrw 1.0

1cae109

Update changelog

3248121

because Grayson doesn't know how to

fix thriftrw integration

f1f056f

Merge pull request #296 from uber/thriftrw-1.0

bf2193e

use thriftrw >=1<2

This was referenced Nov 9, 2015

Preparing for 0.20 release. #297

Merged

WIP 0.21.0 #298

Closed

abhinav closed this Nov 9, 2015

abhinav deleted the 0.20.0 branch November 9, 2015 23:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP 0.20 #295

WIP 0.20 #295

jc-fireball commented Nov 7, 2015

abhinav commented Nov 9, 2015

WIP 0.20 #295

WIP 0.20 #295

Conversation

jc-fireball commented Nov 7, 2015

Removing Deprecated Functionality

Remove Apache Thrift Support

New Functionality

Performance

In Preperation for 1.0

abhinav commented Nov 9, 2015