This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
WIP - 2.0 #328
Closed
WIP - 2.0 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Apache Thrift is no longer supported, we don't need two different implementations of ThriftRequest and ThriftSerializer.
thriftrw only supports the new TChannel interface. This assertion will ensure we don't accidentally call the deprecated version with Thrift endpoints and get cryptic messages.
Heap selection branch merged into mash develop branch.
Merge master into mash yet again
|
There's some good stuff sitting on this branch like peer selection, thriftrw, lint etc. that we probably want to release. I'm wondering if we can split out the backwards-breaking changes and release those separately. |
|
Agreed. Although it's probably worth considering biting the bullet and just releasing the whole, considering the previous minor contains both APIs before we removed deprecated ones. |
|
I really want to avoid breaking changes so I'd rather we just pull out the stuff that's patch-worthy. |
PeerHeap: Make things cheaper
Merge master into mash again
|
@abhinav @junchaoWu @blampe are you guys opposed to renaming this "WIP 1.0 release"? |
|
👍 |
|
@abhinav can you remove the items from the description that have already been merged to master? |
|
done |
|
RIP |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing Deprecated Functionality
client_for- Remove client_for #259thrift_request_builder- Remove thrift_request_builder #264thrift.loadtchannel.tornado.TChannel.registerRemove Apache Thrift Support
testing.data.generated- Remove tests.data.generated #265ThriftRequestin favor ofThriftRWRequest(possibly rename the latter)ThriftSerializerin favor ofThriftRWSerializer(possibly rename the latter)New Functionality
TChannel.registershould just be "raw" endpoints (notas: raw) that receive the raw bytes, parse them manually as required, and return raw bytes in the Response. We should be able to refactorTChannel.{thrift,raw,json}.registerto wrap around this.Performance
In Preperation for 2.0