Provide missing icons for ubuntu pre-installed apps

[ubuntujaggers]

This is my first pull request, hope there are no problems.

Closes #821

• gnome-mines.svg
  

• gnome-mahjongg.svg
  

• gnome-aisleriot.svg
  

• usb-creator-gtk.svg
  

• ubiquity.svg
  

• aptdaemon-download.svg
  

[Feichtmeier]

@ubuntujaggers thanks!

There is something in the svg

[ubuntujaggers]

Oh weird! It didn't look like that on my screen, apologies. Let me work out what went wrong and try again :)

Oh, I know what happened (and why it didn't look like that locally) - I can fix it. Do I need to do anything to the existing PR to withdraw it?

[Feichtmeier]

You need to change the gnome-mines.svg in your local fork and go back to the terminal and do
git add gnome-mines.svg
git commit -m “SOME COOL COMMIT MESSAGE”
git push origin master
again

the commit message should ofc describe what you are doing =D
Edit: also update your PR description with a screenshot :)

[ubuntujaggers]

Brilliant, fixing now.

Basically, there was an element in the svg that was a text character, which I forgot to convert to a vector object. So it was rendering as a character on my laptop, but a rectangle on yours.

[ubuntujaggers]

The svg should look normal for everyone now - can you confirm?

[Feichtmeier]

You didn't push it yet :O

[Feichtmeier]

Perfect

[ubuntujaggers]

Ah, what a doofus - terminal was waiting for my username/password to push it. Okay, it's saying "1 pending check" so it should be okay in a minute.

[ubuntujaggers]

How's that looking?

EDIT: Just saw your screenshot. Brilliant, fingers crossed for the script to work on it :)

[Feichtmeier]

I like it and everything should be okay
@ubuntujaggers now you can make a new branch and checkout to this with
git checkout -b "jaggers_awesome_branch_for_the_next_icon_on_the_list"
Make your next icon and repeat the process BUT with the new branch
git add ... . .. ..
git commit ... . .. ..
git push origin jaggers_awesome_branch_for_the_next_icon_on_the_list

OR

you can update this PR with new commits with the other icons
which should be easier
and we merge all at once

[Feichtmeier]

Yay the next icon 💃

@ubuntujaggers there is some strange "red slash" at the edge of the heart O.o is it virtual blood? ;D

Click on files changed

then click on this File symbol

[ubuntujaggers]

@Feichtmeier Good spot, let me investigate and re-upload.

[ubuntujaggers]

The slash is invisible on my screen but I did find a rogue node in the shape, I think it should be gone now but it's hard for me to check locally. Let me know if there's still some corruption in the svg.

[Feichtmeier]

Fixed 👍

[ubuntujaggers]

How about something like this for Mahjongg:

• Blue glyph is a real Mahjongg character (Unicode turned to vector object);
• Blue and green are colours used in Mahjongg, but I picked shades from the Suru palette.

EDIT: Glyph probably needs a drop shadow, and maybe the green is too vibrant?

EDIT 2: Launcher mockup:

[Feichtmeier]

WoW! +1 I like it

Edit: maybe the highlight is too thick at the top of the stone?

[ubuntujaggers]

Ah good :) See edit, which green do you prefer? Darker or lighter?

[Feichtmeier]

The darker version

[Feichtmeier]

@ubuntujaggers one minor thing for all icons you have commited so far:

Instead of lowering the opacity to 0%
Could you set this "eye icon" to off, thus setting the layer to invisible?

[ubuntujaggers]

Yep, I'll change them now.

[ubuntujaggers]

I don't really know what Transmission does :) but all the icons on Google Images look like a T-shaped lever with a red top. Maybe something like:

[ubuntujaggers]

@ubuntujaggers, are you Mads, which has contacted @Magog64? Or @madsrh ?

I'm not Mads :) That's madsrh.

[ubuntujaggers]

This is my complete set as it currently stands - all are pushed except for Mines and Transmission, which I can push (or revise further) as soon as directed 👍

EDIT: Also, I've raised issues on the Suru repo for Mahjongg and Aisleriot, where I included those icons and offered to fork/submit a PR if @snwh is willing to consider and review them, request further work, etc..

[gusbemacbe]

I'm not Mads :) That's madsrh.

OK, I and @Magog64 are waiting for the @madsrh's answer and let's see if @madsrh accepts and @Magog64 accepts too.

[ubuntujaggers]

I feel like Transmission is very challenging:

For some reason the colours have gone very "off" now I've uploaded it. This version looks pretty good on my laptop but crummy here.

[ubuntujaggers]

This launcher mockup is a better guide to how the colours in the previous post should look:

...but still not faithful. I think the upload/embed makes a decision on how to compress the colours, based on what colours are in the image. Still, tough icon.

[Feichtmeier]

I think its a difference how chrome/firefox renders your PNG you post in here. We can check the SVG in your commit with that "view" button

[ubuntujaggers]

Should I try pushing?

EDIT: Might be better to sleep on this one and try again tomorrow.

Is Mines ready to push?

[gusbemacbe]

@madsrh!

Unfortunately I come to inform that Andrea does not accept. I am sorry for this!

I have explained he needs to follow Sam Hewitt's design guidelines and he can not do third-party icons. And he does not accept.

Andrea sends thanks to you for your interests in inviting him.

[ubuntujaggers]

??

[ubuntujaggers]

[Feichtmeier]

I think you had it with that silver mines icon

[ubuntujaggers]

I think you had it with that silver mines icon

I quite liked it too :) but it got one or two thumbs-down, I think...

[Feichtmeier]

You won't find a design that pleases everyone

[ubuntujaggers]

Ha, true. Some of these icons have been quite hard!

Okay, IMO a bit lighter is better for Transmission:

...and all the icons together (including silver Mines) looks like:

So, if you're happy with those, I can push silver Mines and Transmission.

[ubuntujaggers]

It's a full house! Done. I will work upstream to see if they will be accepted after review/feedback/fixes into Suru.

[Feichtmeier]

Thank you very much jaggers!!! 🎉 🎉 🎉

On Monday we will merge 1 or 2 commits from our master into cosmic.
After this we can merge these SVGs into master (its too late for cosmic now) and I'll do the export.
So the icons will land in 18.04 snap :)

Again: your "plan" from the hub looked very good for "all of us"

[ubuntujaggers]

its too late for cosmic now

Yes, sorry that took a bit longer than hoped, but some were a bit harder :) I'm glad we did further revisions of all the icons instead of staying with the original concepts (e.g., the non-pixel mahjong tile on the green background) because I think they look much better now.

[jbicha]

I think the issue with third party icons is not just about trademark guidelines and logo licenses.

Both Transmission and LibreOffice have their own highly successful branding and identities. I am thinking their developers may want Ubuntu to ask permission before significantly changing their app icons in the default install of one of the most popular Linux distributions. I think this is the big concern that snwh had with theming third-party icons.

I don't think that's a concern for the other icons mentioned here which are either GNOME apps or apps unique to Ubuntu.

So as was mentioned elsewhere, I encourage you to split at least Transmission into a separate pull request.

[Feichtmeier]

@jbicha good point, let's split it out
But what about the fact that there exists a humanity transmission icon? 🤔

[ubuntujaggers]

Do I have to do anything about Transmission here, or do you just not merge that one...?

[jbicha]

But what about the fact that there exists a humanity transmission icon?

No there isn't. 😄

[ubuntujaggers]

I think @jbicha might be right, the Ubuntu/Gnome icon for Transmission is on Wikimedia commons as source: Ubuntu packages but author: Transmission project. So if it isn't the same as the normal Transmission icon, I suspect it's just an older one or something?

[Feichtmeier]

Cut the icon out of your folder and put it into some folder ouside of .../yaru and commit this "change" =)
Then switch the branch

Then we ask LO and the transmission people

[ubuntujaggers]

Okay, that's being checked now.

[Feichtmeier]

@ubuntujaggers alright

Made a new branch with Surus recent changes + your icons + exports
( https://github.com/ubuntu/yaru/tree/Suru_icon_updates )
Used your usb-gtk-creator for now, since I personally prefer it, but ofc if the majority prefers the other icon we can always pull it
So I would like to close this PR now, since we don't want to merge this into master now.
You can fetch/checkout that new branch then.

Are you okay with this @ubuntujaggers or do you need the PR still?

Edit: you did a really good job

[gusbemacbe]

I have a small suggestion: Language Support icon reminders me Google Translate icon and applying it for Language Support icon is bad because the user will think it is a translation app.

[ubuntujaggers]

@Feichtmeier cheers! I'm glad they don't look out of place in the shell because that was the one thing I found hard to mock up with 100% realism.

Yep, I'll close the PR now :)

Re: USB creator, I also prefer a Suru-shaped icon for this if it shows up in the app grid, and we can always incorporate an arrow or other element that suggests something is being written. But equally, feel free to scrap it if that suits better.