Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts to use JEDI skylab v7 #92

Merged
merged 21 commits into from
May 2, 2024

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Apr 29, 2024

Description

  • Update the version of JEDI skylab from v4 to v7.
  • Update ex-scripts to use skylab v7 and to meet the NCO implementation standards.
  • Replace the submodule DA_update with apply_incr directly.
  • Add the templates and configuration files in DA_update to parm.
  • Create the ush directory.

Anticipated changes to regression tests:

  • Is baseline change expected ?

Subcomponents involved:

  • DA_update (ufs-community/land-DA)
  • ufsLand.fd (NOAA-EPIC/ufs-land-driver-emc-dev)
  • ufs_model.fd (ufs-community/ufs-weather-model)
  • vector2tile_converter.fd (NOAA-PSL/land-vector2tile)
  • none

Linked PR's and Issues:

Fixes Issues #46, #89, #90, and #91

Testing (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • CI
    • Completed
  • PW-Clouds
    • AWS
    • AZURE
    • GCP

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Apr 29, 2024

In Ctest, tests 5 and 6 failed when the result files were compared to the test_base files:

  • test 5 (tile2vector)
Not equal to tolerance rtol=1e-08, atol=1e-06

Mismatched elements: 471 / 128254 (0.367%)
Max absolute difference: 0.00412437
Max relative difference: 0.04656209
  • test 6 (land driver)
AssertionError:
Not equal to tolerance rtol=1e-08, atol=1e-06

Mismatched elements: 443 / 128254 (0.345%)
Max absolute difference: 0.0111796
Max relative difference: 0.09948057

This might be caused by the new version of JEDI (skylab v.7), but I am not sure.

@chan-hoo chan-hoo linked an issue Apr 29, 2024 that may be closed by this pull request
@jkbk2004
Copy link
Collaborator

In Ctest, tests 5 and 6 failed when the result files were compared to the test_base files:

  • test 5 (tile2vector)
Not equal to tolerance rtol=1e-08, atol=1e-06

Mismatched elements: 471 / 128254 (0.367%)
Max absolute difference: 0.00412437
Max relative difference: 0.04656209
  • test 6 (land driver)
AssertionError:
Not equal to tolerance rtol=1e-08, atol=1e-06

Mismatched elements: 443 / 128254 (0.345%)
Max absolute difference: 0.0111796
Max relative difference: 0.09948057

This might be caused by the new version of JEDI (skylab v.7), but I am not sure.

No surprise to see impact on the computed result with jedi bundle update even along with stack update (previously installed before this pr). It will be good to check unit of mean/max diff values. Scatter plots for sanity check.

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented May 1, 2024

@jkbk2004, with the new base files:

Orion-login-1[41] chjeon$ ctest --rerun-failed
Test project /work/noaa/epic/chjeon/landda_sub/land-DA_workflow/sorc/build
    Start 5: test_tile2vector
1/2 Test #5: test_tile2vector .................   Passed    2.37 sec
    Start 6: test_land_driver
2/2 Test #6: test_land_driver .................   Passed    7.82 sec

100% tests passed, 0 tests failed out of 2

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented May 2, 2024

Orion-login-1[7] chjeon$ ctest
Test project /work/noaa/epic/chjeon/landda_sub/land-DA_workflow/sorc/build
    Start 1: test_vector2tile
1/7 Test #1: test_vector2tile .................   Passed   12.56 sec
    Start 2: test_create_ens
2/7 Test #2: test_create_ens ..................   Passed   19.52 sec
    Start 3: test_letkfoi_snowda
3/7 Test #3: test_letkfoi_snowda ..............   Passed   71.65 sec
    Start 4: test_apply_jediincr
4/7 Test #4: test_apply_jediincr ..............   Passed    4.44 sec
    Start 5: test_tile2vector
5/7 Test #5: test_tile2vector .................   Passed   13.50 sec
    Start 6: test_land_driver
6/7 Test #6: test_land_driver .................   Passed    9.43 sec
    Start 7: test_ufs_datm_land
7/7 Test #7: test_ufs_datm_land ...............   Passed  513.33 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 644.70 sec

@chan-hoo chan-hoo merged commit eac3bb7 into ufs-community:develop May 2, 2024
2 checks passed
@chan-hoo chan-hoo deleted the feature/skylab7 branch May 7, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants