-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fifth reconciliation PR from production/RRFS.v1 #2485
Fifth reconciliation PR from production/RRFS.v1 #2485
Conversation
As of Monday morning Dec. 9, I'm re-running regression tests due to a bug fix that I needed to add into ufs-community/ccpp-physics#231. This bugfix is expected to change the same tests as in ufs-community/ccpp-physics#194: merra2_thompson intel |
@grantfirl can you sync up branches? We can start working on this pr. |
OK, it should be ready to test. Regarding my retests, they actually didn't cause changes to the other tests (merra2_thompson intel |
WCOSS2 and Acorn are down tomorrow. We might need to move on to a PR that doesn't change baselines. |
@grantfirl we can restart testing this pr. can you sync up branch one more time? |
@jkbk2004 Finished syncing |
@BrianCurtis-NOAA @FernandoAndrade-NOAA We can go ahead to merge if we skip acorn. |
I have a ticket about some Acorn issues sent out without a resolution yet. We can skip that machine. |
@grantfirl new fv3 hash is NOAA-EMC/fv3atm@a7d46ee |
Commit Queue Requirements:
Description:
This work is identical to #2214, but targeting the develop branch instead.
This is work from @jordanschnell and their description is as follows:
For ebb_dcycle==1 (retrospective fire emissions), the 3-d emissions were incorrectly assgined assigned at all levels using the surface data.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: